Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java

Issue 2022303002: Always disable session invalidations when not on the recent tabs page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java
index ad1ee254db75c26ad6b428a0ca9fd775e7da41f0..95caaefe8066adee5ea7ad9d482250f610a7ec83 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java
@@ -18,14 +18,11 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.library_loader.ProcessInitException;
-import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.browser.init.BrowserParts;
import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
import org.chromium.chrome.browser.init.EmptyBrowserParts;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.components.invalidation.PendingInvalidation;
-import org.chromium.sync.ModelType;
-import org.chromium.sync.ModelTypeHelper;
import org.chromium.sync.signin.ChromeSigninController;
import java.util.concurrent.Semaphore;
@@ -143,12 +140,5 @@ public class ChromeBrowserSyncAdapter extends AbstractThreadedSyncAdapter {
int objectSource, String objectId, long version, String payload) {
InvalidationServiceFactory.getForProfile(Profile.getLastUsedProfile())
.notifyInvalidationToNativeChrome(objectSource, objectId, version, payload);
-
- // Count the number of sessions sync invalidations to evaluate effectiveness of
- // AndroidSessionNotifications field trial. The histogram is recorded here because
- // RecordHistogram requires the native library to be loaded.
- if (ModelTypeHelper.toNotificationType(ModelType.SESSIONS).equals(objectId)) {
- RecordHistogram.recordBooleanHistogram("Sync.InvalidationSessionsAndroid", true);
- }
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698