chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java - Issue 2022303002: Always disable session invalidations when not on the recent tabs page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

Issue 2022303002: Always disable session invalidations when not on the recent tabs page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

index 13cf98423b5bbca1025de4d7775efdff1ef290e0..6564edae513819804453a05edfac2c3438b2e159 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

@@ -277,15 +277,10 @@ public class InvalidationController implements ApplicationStatus.ApplicationStat

synchronized (LOCK) {

if (sInstance == null) {

// The PageRevisitInstrumentation trial needs sessions invalidations to be on such

- // that local session data is current and can be used to perform checks. Its

- // preference should override the AndroidSessionNotifications trial.

+ // that local session data is current and can be used to perform checks.

boolean requireInvalidationsForInstrumentation =

FieldTrialList.findFullName("PageRevisitInstrumentation").equals("Enabled");

- boolean tryToDisableInvalidationsAsOptimization =

- FieldTrialList.findFullName("AndroidSessionNotifications")

- .equals("Disabled");

- boolean canDisableSessionInvalidations = !requireInvalidationsForInstrumentation

- && tryToDisableInvalidationsAsOptimization;

+ boolean canDisableSessionInvalidations = !requireInvalidationsForInstrumentation;

boolean canUseGcmUpstream =

FieldTrialList.findFullName("InvalidationsGCMUpstream").equals("Enabled");