components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/form_autofill_util.cc ('K') | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/core/browser/form_field.cc » ('j') | components/autofill/core/browser/form_field_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index b114b09c17ac233d6f3c3d1d7df069f5cb08fa77..e3ac080b3cada734e62810ce6e0ac0bb00a0d57a 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -3761,7 +3761,7 @@ class AutofillMetricsParseQueryResponseTest : public testing::Test {

FormFieldData checkable_field;

checkable_field.label = ASCIIToUTF16("radio_button");

checkable_field.form_control_type = "radio";

- checkable_field.is_checkable = true;

+ SetCheckStatus(&checkable_field, true, false);

vabr (Chromium) 2016/06/06 12:39:30 Please assign directly: checkable_field.check_stat

form.fields.push_back(checkable_field);

forms_.push_back(new FormStructure(form));