Merge autofill::FormFieldData::is_checkable and is_checked

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
@@ skipping 3743 matching lines @@
     form.fields.push_back(field);
 
     field.label = ASCIIToUTF16("address");
     field.name = ASCIIToUTF16("address");
     form.fields.push_back(field);
 
     // Checkable fields should be ignored in parsing
     FormFieldData checkable_field;
     checkable_field.label = ASCIIToUTF16("radio_button");
     checkable_field.form_control_type = "radio";
-    checkable_field.is_checkable = true;
+    SetCheckStatus(&checkable_field, true, false);

[vabr (Chromium), 2016/06/06 12:39:30]

Please assign directly:
checkable_field.check_status = FormFieldData::CHECKABLE_BUT_UNCHECKED;

that is more readable than the function call here (one has to know the
SetCheckStatus definition to understand the meaning of the 2nd and 3rd
argument).

     form.fields.push_back(checkable_field);
 
     forms_.push_back(new FormStructure(form));
 
     field.label = ASCIIToUTF16("email");
     field.name = ASCIIToUTF16("email");
     form.fields.push_back(field);
 
     field.label = ASCIIToUTF16("password");
     field.name = ASCIIToUTF16("password");
@@ skipping 105 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples("Autofill.ServerResponseHasDataForForm"),
       ElementsAre(Bucket(true, 2)));
 
   // No RAPPOR metrics are logged in the case there is at least some server data
   // available for all forms.
   EXPECT_EQ(0, rappor_service_.GetReportsCount());
 }
 
 }  // namespace autofill