components/autofill/core/browser/form_field_unittest.cc - Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_field_unittest.cc

Issue 2022123002: Merge autofill::FormFieldData::is_checkable and is_checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_metrics_unittest.cc ('K') | « components/autofill/core/browser/form_field.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | components/autofill/core/common/form_field_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_field_unittest.cc

diff --git a/components/autofill/core/browser/form_field_unittest.cc b/components/autofill/core/browser/form_field_unittest.cc

index b08730126c9f2982b960bfc87e5825b0f0431567..68aa042eae224cd88fd7ec20e789a23561765f8a 100644

--- a/components/autofill/core/browser/form_field_unittest.cc

+++ b/components/autofill/core/browser/form_field_unittest.cc

@@ -131,12 +131,12 @@ TEST(FormFieldTest, ParseFormFields) {

field_data.label = ASCIIToUTF16("Address line1");

fields.push_back(new AutofillField(field_data, field_data.label));

- field_data.is_checkable = true;

+ SetCheckStatus(&field_data, true, false);

vabr (Chromium) 2016/06/06 12:39:30 Please assign directly, see my comment in componen

field_data.label = ASCIIToUTF16("Is PO Box");

fields.push_back(new AutofillField(field_data, field_data.label));

// reset |is_checkable| to false.

- field_data.is_checkable = false;

+ SetCheckStatus(&field_data, false, false);

vabr (Chromium) 2016/06/06 12:39:30 Here as well, please assign directly.

field_data.label = ASCIIToUTF16("Address line2");

fields.push_back(new AutofillField(field_data, field_data.label));