Use only DIPs size in ClientResolution.

Use only DIPs size in ClientResolution.

ClientResolution message contains DIPs and device size fields. DIPs
size was marked as legacy, but it was actually used by the host. It's
best to use DIPs for consistency with other messages, particularly
VideoTrackLayout. marked device-pixel size as deprecated and the host
now works when width/height fields are not specified.

Committed: https://crrev.com/54624e1a736de7222d7405f5337f858bd4b8c2e1
Cr-Commit-Position: refs/heads/master@{#397102}

[Sergey Ulanov, 2016-05-30 08:37:17]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-05-30 08:37:41]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-05-31 20:40:47]

lgtm

https://codereview.chromium.org/2021773002/diff/20001/remoting/client/plugin/...
File remoting/client/plugin/chromoting_instance.cc (right):

https://codereview.chromium.org/2021773002/diff/20001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:819: // Include the legacy width &
height in DIPs for use by older hosts.
s/DIPs/device pixels/

https://codereview.chromium.org/2021773002/diff/20001/remoting/protocol/host_...
File remoting/protocol/host_control_dispatcher.cc (right):

https://codereview.chromium.org/2021773002/diff/20001/remoting/protocol/host_...
remoting/protocol/host_control_dispatcher.cc:84:
host_stub_->NotifyClientResolution(resolution);
It seems odd that this is the only message we validate at this level. If you
think that this is the right place to validate, then this is fine as-is, but I
think we should add validation for the other messages here as well (not in this
CL).

[Sergey Ulanov, 2016-06-01 10:08:51]

https://codereview.chromium.org/2021773002/diff/20001/remoting/client/plugin/...
File remoting/client/plugin/chromoting_instance.cc (right):

https://codereview.chromium.org/2021773002/diff/20001/remoting/client/plugin/...
remoting/client/plugin/chromoting_instance.cc:819: // Include the legacy width &
height in DIPs for use by older hosts.
On 2016/05/31 20:40:47, Jamie wrote:
> s/DIPs/device pixels/

Done.

https://codereview.chromium.org/2021773002/diff/20001/remoting/protocol/host_...
File remoting/protocol/host_control_dispatcher.cc (right):

https://codereview.chromium.org/2021773002/diff/20001/remoting/protocol/host_...
remoting/protocol/host_control_dispatcher.cc:84:
host_stub_->NotifyClientResolution(resolution);
On 2016/05/31 20:40:47, Jamie wrote:
> It seems odd that this is the only message we validate at this level. If you
> think that this is the right place to validate, then this is fine as-is, but I
> think we should add validation for the other messages here as well (not in
this
> CL).

Agree. Added a TODO.

[Sergey Ulanov, 2016-06-01 10:08:54]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-06-01 10:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2021773002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-01 10:09:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021773002/40001

[commit-bot: I haz the power, 2016-06-01 10:54:47]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-01 10:55:57]

Description was changed from

==========
Use only DIPs size in ClientResolution.

ClientResolution message contains DIPs and device size fields. DIPs
size was marked as legacy, but it was actually used by the host. It's
best to use DIPs for consistency with other messages, particularly
VideoTrackLayout. marked device-pixel size as deprecated and the host
now works when width/height fields are not specified.
==========

to

==========
Use only DIPs size in ClientResolution.

ClientResolution message contains DIPs and device size fields. DIPs
size was marked as legacy, but it was actually used by the host. It's
best to use DIPs for consistency with other messages, particularly
VideoTrackLayout. marked device-pixel size as deprecated and the host
now works when width/height fields are not specified.

Committed: https://crrev.com/54624e1a736de7222d7405f5337f858bd4b8c2e1
Cr-Commit-Position: refs/heads/master@{#397102}
==========

[commit-bot: I haz the power, 2016-06-01 10:55:58]

Patchset 2 (id:??) landed as
https://crrev.com/54624e1a736de7222d7405f5337f858bd4b8c2e1
Cr-Commit-Position: refs/heads/master@{#397102}