Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: remoting/host/client_session.cc

Issue 2021773002: Use only DIPs size in ClientResolution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/chromoting_instance.cc ('k') | remoting/proto/control.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/client_session.cc
diff --git a/remoting/host/client_session.cc b/remoting/host/client_session.cc
index 83e75ec537f93bb777589cc82ad1c6cf499ee385..dc40047992085e5868630c803d01801acc3fc5d5 100644
--- a/remoting/host/client_session.cc
+++ b/remoting/host/client_session.cc
@@ -111,14 +111,7 @@ ClientSession::~ClientSession() {
void ClientSession::NotifyClientResolution(
const protocol::ClientResolution& resolution) {
DCHECK(CalledOnValidThread());
-
- // TODO(sergeyu): Move these checks to protocol layer.
- if (!resolution.has_dips_width() || !resolution.has_dips_height() ||
- resolution.dips_width() < 0 || resolution.dips_height() < 0 ||
- resolution.width() <= 0 || resolution.height() <= 0) {
- LOG(ERROR) << "Received invalid ClientResolution message.";
- return;
- }
+ DCHECK(resolution.dips_width() > 0 && resolution.dips_height() > 0);
VLOG(1) << "Received ClientResolution (dips_width="
<< resolution.dips_width() << ", dips_height="
« no previous file with comments | « remoting/client/plugin/chromoting_instance.cc ('k') | remoting/proto/control.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698