Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2021203002: Rename ScriptWrappable::newLocalWrapper to ScriptWrappable::mainWorldWrapper (Closed)

Created:
4 years, 8 months ago by haraken
Modified:
4 years, 8 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, haraken, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScriptWrappable::newLocalWrapper to ScriptWrappable::mainWorldWrapper To clarify that it returns a main world's wrapper. To avoid the method from being used randomly, this CL makes the method private. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/2658bb52232e9d1fcb4b45b2846f4b69e9e44800 Cr-Commit-Position: refs/heads/master@{#396796}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h View 1 2 3 chunks +20 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
haraken
PTAL (This is a change requested by kbr offline.)
4 years, 8 months ago (2016-05-31 04:40:22 UTC) #3
Yuki
lgtm https://codereview.chromium.org/2021203002/diff/20001/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h File third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h (right): https://codereview.chromium.org/2021203002/diff/20001/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h#newcode167 third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h:167: friend class DOMDataStore; Maybe, better to comment why ...
4 years, 8 months ago (2016-05-31 04:43:11 UTC) #4
haraken
https://codereview.chromium.org/2021203002/diff/20001/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h File third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h (right): https://codereview.chromium.org/2021203002/diff/20001/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h#newcode167 third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h:167: friend class DOMDataStore; On 2016/05/31 04:43:11, Yuki wrote: > ...
4 years, 8 months ago (2016-05-31 04:44:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021203002/40001
4 years, 8 months ago (2016-05-31 04:45:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-05-31 07:02:42 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 07:03:52 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2658bb52232e9d1fcb4b45b2846f4b69e9e44800
Cr-Commit-Position: refs/heads/master@{#396796}

Powered by Google App Engine
This is Rietveld 408576698