third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp - Issue 2021203002: Rename ScriptWrappable::newLocalWrapper to ScriptWrappable::mainWorldWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

Issue 2021203002: Rename ScriptWrappable::newLocalWrapper to ScriptWrappable::mainWorldWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

index 4f0c1913b21df8d96ee73bdd4e169bd2d74754f8..abd07aac4fd4805e7f2c117035a06535eefed0db 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

@@ -12,7 +12,7 @@ namespace blink {

struct SameSizeAsScriptWrappable {

virtual ~SameSizeAsScriptWrappable() { }

- v8::Persistent<v8::Object> m_wrapper;

+ v8::Persistent<v8::Object> m_mainWorldWrapper;

};

static_assert(sizeof(ScriptWrappable) <= sizeof(SameSizeAsScriptWrappable), "ScriptWrappable should stay small");

@@ -39,7 +39,7 @@ v8::Local<v8::Object> ScriptWrappable::associateWithWrapper(v8::Isolate* isolate

void ScriptWrappable::markWrapper(v8::Isolate* isolate) const

{

if (containsWrapper())

- ScriptWrappableVisitor::markWrapper(&m_wrapper, isolate);

+ ScriptWrappableVisitor::markWrapper(&m_mainWorldWrapper, isolate);

}

} // namespace blink