Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 2021203002: Rename ScriptWrappable::newLocalWrapper to ScriptWrappable::mainWorldWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/V8HiddenValue.h" 5 #include "bindings/core/v8/V8HiddenValue.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 44
45 bool V8HiddenValue::deleteHiddenValue(ScriptState* scriptState, v8::Local<v8::Ob ject> object, v8::Local<v8::String> key) 45 bool V8HiddenValue::deleteHiddenValue(ScriptState* scriptState, v8::Local<v8::Ob ject> object, v8::Local<v8::String> key)
46 { 46 {
47 // Actually deleting the value would make force the object into dictionary m ode which is unnecessarily slow. Instead, we replace the hidden value with "unde fined". 47 // Actually deleting the value would make force the object into dictionary m ode which is unnecessarily slow. Instead, we replace the hidden value with "unde fined".
48 return v8CallBoolean(object->SetPrivate(scriptState->context(), v8::Private: :ForApi(scriptState->isolate(), key), v8::Undefined(scriptState->isolate()))); 48 return v8CallBoolean(object->SetPrivate(scriptState->context(), v8::Private: :ForApi(scriptState->isolate(), key), v8::Undefined(scriptState->isolate())));
49 } 49 }
50 50
51 v8::Local<v8::Value> V8HiddenValue::getHiddenValueFromMainWorldWrapper(ScriptSta te* scriptState, ScriptWrappable* wrappable, v8::Local<v8::String> key) 51 v8::Local<v8::Value> V8HiddenValue::getHiddenValueFromMainWorldWrapper(ScriptSta te* scriptState, ScriptWrappable* wrappable, v8::Local<v8::String> key)
52 { 52 {
53 v8::Local<v8::Object> wrapper = wrappable->newLocalWrapper(scriptState->isol ate()); 53 v8::Local<v8::Object> wrapper = wrappable->mainWorldWrapper(scriptState->iso late());
54 return wrapper.IsEmpty() ? v8::Local<v8::Value>() : getHiddenValue(scriptSta te, wrapper, key); 54 return wrapper.IsEmpty() ? v8::Local<v8::Value>() : getHiddenValue(scriptSta te, wrapper, key);
55 } 55 }
56 56
57 } // namespace blink 57 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698