Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js

Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/f2dfca4180ffdf50c2c9d926d8113d61d5886efc
Cr-Commit-Position: refs/heads/master@{#396738}

[Srirama, 2016-05-29 12:55:10]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css-*, controls-drag-* and controls-overlay-*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-29 12:55:26]

Description was changed from

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css-*, controls-drag-* and controls-overlay-*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-29 12:56:05]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-05-29 12:56:05]

PTAL

[fs, 2016-05-29 14:28:17]

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-css-overload.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:14: <video
class="nocontrols notimeline" width=300 height=200 controls></video>
Should probably keep the two <video> from the old version.

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:16:
async_test(function(t) {
The old version wasn't async - IIRC, this test only requires a layout to test
properly. (It's possible I'm mixing this up with some other issue though, so
check the origin of this test.)

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var x;
Maybe group these and call them "currentMousePosition" or something like that.

[Srirama, 2016-05-30 13:19:19]

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-css-overload.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:14: <video
class="nocontrols notimeline" width=300 height=200 controls></video>
On 2016/05/29 14:28:17, fs wrote:
> Should probably keep the two <video> from the old version.

Done.

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:16:
async_test(function(t) {
On 2016/05/29 14:28:17, fs wrote:
> The old version wasn't async - IIRC, this test only requires a layout to test
> properly. (It's possible I'm mixing this up with some other issue though, so
> check the origin of this test.)

I don't know what to keep in the test() function, so i thought of adding some
event and that is how i ended up in async_test. So is empty test() fine?
The history dates back to 7years :) http://trac.webkit.org/changeset/44546 and,
it is a layout issue as you said.

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var x;
On 2016/05/29 14:28:17, fs wrote:
> Maybe group these and call them "currentMousePosition" or something like that.

Done. Is this what you are expecting, or did i mess it up? The stmts became a
bit lengthy with this new structure.

[foolip, 2016-05-30 13:33:28]

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var
currentMousePosition = {
Any reason to group these into an object? fooPosition.barPosition looks a bit
much.

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:11:
seekPosition: [],
Suggest null as the initial value. This empty array is never used for anything.

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:22: function
test() {
Suggest renaming this to playing, calling it test makes it less clear above that
it's not testharness.js's test method we're talking about.

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:42:
++(currentMousePosition.moveCount);
Looks funny, can you use currentMousePosition.moveCount++ instead?

[foolip, 2016-05-30 13:34:15]

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var x;
On 2016/05/30 13:19:19, Srirama wrote:
> On 2016/05/29 14:28:17, fs wrote:
> > Maybe group these and call them "currentMousePosition" or something like
that.
> 
> Done. Is this what you are expecting, or did i mess it up? The stmts became a
> bit lengthy with this new structure.

Oh, you talked about this :) Wait for fs to comment before listening to my
suggestion.

[fs, 2016-05-30 13:37:22]

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-css-overload.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:16:
async_test(function(t) {
On 2016/05/30 at 13:19:19, Srirama wrote:
> On 2016/05/29 14:28:17, fs wrote:
> > The old version wasn't async - IIRC, this test only requires a layout to
test
> > properly. (It's possible I'm mixing this up with some other issue though, so
> > check the origin of this test.)
> 
> I don't know what to keep in the test() function, so i thought of adding some
event and that is how i ended up in async_test. So is empty test() fine?
> The history dates back to 7years :) http://trac.webkit.org/changeset/44546
and, it is a layout issue as you said.

Thanks for digging that up. Empty test() seems fine to me. If you'd like it to
be non-empty I guess you could stick a:

// Force layout
document.body.offsetLeft;

in it.

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var x;
On 2016/05/30 at 13:19:19, Srirama wrote:
> On 2016/05/29 14:28:17, fs wrote:
> > Maybe group these and call them "currentMousePosition" or something like
that.
> 
> Done. Is this what you are expecting, or did i mess it up? The stmts became a
bit lengthy with this new structure.

I was thinking of 'x' and 'y' only, like:

var currentMousePosition = { x: 0, y: 0 };

I guess it's a bit unfortunate that mediaControlsButtonCoordinates returns an
array rather than an object.

[Srirama, 2016-05-30 13:59:22]

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-css-overload.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-css-overload.html:16:
async_test(function(t) {
On 2016/05/30 13:37:22, fs wrote:
> On 2016/05/30 at 13:19:19, Srirama wrote:
> > On 2016/05/29 14:28:17, fs wrote:
> > > The old version wasn't async - IIRC, this test only requires a layout to
> test
> > > properly. (It's possible I'm mixing this up with some other issue though,
so
> > > check the origin of this test.)
> > 
> > I don't know what to keep in the test() function, so i thought of adding
some
> event and that is how i ended up in async_test. So is empty test() fine?
> > The history dates back to 7years :) http://trac.webkit.org/changeset/44546
> and, it is a layout issue as you said.
> 
> Thanks for digging that up. Empty test() seems fine to me. If you'd like it to
> be non-empty I guess you could stick a:
> 
> // Force layout
> document.body.offsetLeft;
> 
> in it.

Fine, i will also go with empty one.

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:10: var x;
On 2016/05/30 13:37:22, fs wrote:
> On 2016/05/30 at 13:19:19, Srirama wrote:
> > On 2016/05/29 14:28:17, fs wrote:
> > > Maybe group these and call them "currentMousePosition" or something like
> that.
> > 
> > Done. Is this what you are expecting, or did i mess it up? The stmts became
a
> bit lengthy with this new structure.
> 
> I was thinking of 'x' and 'y' only, like:
> 
> var currentMousePosition = { x: 0, y: 0 };
> 
> I guess it's a bit unfortunate that mediaControlsButtonCoordinates returns an
> array rather than an object.

Done, assuming that you still want this change.

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/controls-drag-timebar.html (right):

https://codereview.chromium.org/2020893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/controls-drag-timebar.html:22: function
test() {
On 2016/05/30 13:33:28, Philip Jägenstedt wrote:
> Suggest renaming this to playing, calling it test makes it less clear above
that
> it's not testharness.js's test method we're talking about.

Done.

[fs, 2016-05-30 14:35:41]

lgtm

[Srirama, 2016-05-30 15:56:34]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-05-30 15:56:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020893002/40001

[commit-bot: I haz the power, 2016-05-30 17:05:26]

Description was changed from

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-30 17:05:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-30 17:07:03]

Description was changed from

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert controls-css*, controls-drag* and controls-overlay* tests to
testharness.js

Cleaning up controls-css*, controls-drag* and controls-overlay*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/f2dfca4180ffdf50c2c9d926d8113d61d5886efc
Cr-Commit-Position: refs/heads/master@{#396738}
==========

[commit-bot: I haz the power, 2016-05-30 17:07:04]

Patchset 3 (id:??) landed as
https://crrev.com/f2dfca4180ffdf50c2c9d926d8113d61d5886efc
Cr-Commit-Position: refs/heads/master@{#396738}