third_party/WebKit/LayoutTests/media/controls-css-overload.html - Issue 2020893002: Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-css-overload.html

Issue 2020893002: Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/controls-css-overload-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/controls-drag-timebar.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"	1 <!DOCTYPE html>

2 "http://www.w3.org/TR/html4/strict.dtd">	2 <title>Testing that overloading some controls doesn't crash the browser</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <style>

	7 .nocontrols::-webkit-media-controls-panel {

	8 display:none;

	9 }

	10 .notimeline::-webkit-media-controls-timeline-container {

	11 display:none;

	12 }

	13 </style>

	14 <video class="nocontrols notimeline" width=300 height=200 controls></video>
	fs 2016/05/29 14:28:17 Should probably keep the two <video> from the old Should probably keep the two <video> from the old version. Srirama 2016/05/30 13:19:19 Done. Show quoted text On 2016/05/29 14:28:17, fs wrote: > Should probably keep the two <video> from the old version. Done.
	15 <script>

	16 async_test(function(t) {
	fs 2016/05/29 14:28:17 The old version wasn't async - IIRC, this test onl The old version wasn't async - IIRC, this test only requires a layout to test properly. (It's possible I'm mixing this up with some other issue though, so check the origin of this test.) Srirama 2016/05/30 13:19:19 I don't know what to keep in the test() function, Show quoted text On 2016/05/29 14:28:17, fs wrote: > The old version wasn't async - IIRC, this test only requires a layout to test > properly. (It's possible I'm mixing this up with some other issue though, so > check the origin of this test.) I don't know what to keep in the test() function, so i thought of adding some event and that is how i ended up in async_test. So is empty test() fine? The history dates back to 7years :) http://trac.webkit.org/changeset/44546 and, it is a layout issue as you said. fs 2016/05/30 13:37:22 Thanks for digging that up. Empty test() seems fin Show quoted text On 2016/05/30 at 13:19:19, Srirama wrote: > On 2016/05/29 14:28:17, fs wrote: > > The old version wasn't async - IIRC, this test only requires a layout to test > > properly. (It's possible I'm mixing this up with some other issue though, so > > check the origin of this test.) > > I don't know what to keep in the test() function, so i thought of adding some event and that is how i ended up in async_test. So is empty test() fine? > The history dates back to 7years :) http://trac.webkit.org/changeset/44546 and, it is a layout issue as you said. Thanks for digging that up. Empty test() seems fine to me. If you'd like it to be non-empty I guess you could stick a: // Force layout document.body.offsetLeft; in it. Srirama 2016/05/30 13:59:22 Fine, i will also go with empty one. Show quoted text On 2016/05/30 13:37:22, fs wrote: > On 2016/05/30 at 13:19:19, Srirama wrote: > > On 2016/05/29 14:28:17, fs wrote: > > > The old version wasn't async - IIRC, this test only requires a layout to > test > > > properly. (It's possible I'm mixing this up with some other issue though, so > > > check the origin of this test.) > > > > I don't know what to keep in the test() function, so i thought of adding some > event and that is how i ended up in async_test. So is empty test() fine? > > The history dates back to 7years :) http://trac.webkit.org/changeset/44546 > and, it is a layout issue as you said. > > Thanks for digging that up. Empty test() seems fine to me. If you'd like it to > be non-empty I guess you could stick a: > > // Force layout > document.body.offsetLeft; > > in it. Fine, i will also go with empty one.
	17 var video = document.querySelector("video");

	18 video.src = findMediaFile("video", "content/test");

3	19

4 <html>	20 video.oncanplaythrough = t.step_func_done();

5 <head>	21 });

6 <title>Testing that overloading some controls doesn't crash the browser</tit le>	22 </script>

7 <style>

8 .nocontrols::-webkit-media-controls-panel{

9 display:none;

10 }

11 .notimeline::-webkit-media-controls-timeline-container{

12 display:none;

13 }

14 </style>

15 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

16 (Please avoid writing new tests using video-test.js) -->

17 <script src=video-test.js></script>

18 </head>

19 <body>

20 <video class="nocontrols" width=300 height=200 controls></video>

21 <video class="notimeline" width=300 height=200 controls></video>

22 <script>

23 consoleWrite("I did not crash");

24 endTest();

25 </script>

26 </body>	23 </body>

27 </html>	24 </html>

OLD	NEW