Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/LayoutTests/media/controls-css-overload.html

Issue 2020893002: Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/controls-css-overload-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/controls-css-overload.html
diff --git a/third_party/WebKit/LayoutTests/media/controls-css-overload.html b/third_party/WebKit/LayoutTests/media/controls-css-overload.html
index cd66186d7ca250ecd9afe188041935b65205909f..2a9f63c062de4f7ab9811d91df134acb0184a8f3 100644
--- a/third_party/WebKit/LayoutTests/media/controls-css-overload.html
+++ b/third_party/WebKit/LayoutTests/media/controls-css-overload.html
@@ -1,27 +1,22 @@
-<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"
- "http://www.w3.org/TR/html4/strict.dtd">
-
-<html>
-<head>
- <title>Testing that overloading some controls doesn't crash the browser</title>
- <style>
- .nocontrols::-webkit-media-controls-panel{
- display:none;
- }
- .notimeline::-webkit-media-controls-timeline-container{
- display:none;
- }
- </style>
- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=video-test.js></script>
-</head>
-<body>
- <video class="nocontrols" width=300 height=200 controls></video>
- <video class="notimeline" width=300 height=200 controls></video>
- <script>
- consoleWrite("I did not crash");
- endTest();
- </script>
+<!DOCTYPE html>
+<title>Testing that overloading some controls doesn't crash the browser</title>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="media-file.js"></script>
+<style>
+ .nocontrols::-webkit-media-controls-panel {
+ display:none;
+ }
+ .notimeline::-webkit-media-controls-timeline-container {
+ display:none;
+ }
+</style>
+<video class="nocontrols" width=300 height=200 controls></video>
+<video class="notimeline" width=300 height=200 controls></video>
+<script>
+test(function() {
+ // Test is complete if there is no crash.
+});
+</script>
</body>
-</html>
+</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/controls-css-overload-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698