Revert "build: remove diagnose_goma step to stop leaks"

Revert "build: remove diagnose_goma step to stop leaks"

This reverts commit 76cb0afec1641517e990d9595c84088b4c6e64eb.

BUG=chromium:605440

[Yoshisato Yanagisawa, 2016-05-27 08:36:59]

yyanagisawa@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, ukai@chromium.org

[Yoshisato Yanagisawa, 2016-05-27 08:36:59]

I understand the leak in diagnose_goma.py has already been fixed in the latest
goma client.
Let me revert this change.

[Yoshisato Yanagisawa, 2016-05-30 05:55:56]

I think diagnose_goma is essential for judging it ok to release the client or
not.
Can I ask you to review this?

[ukai, 2016-05-30 06:20:36]

lgtm

[Paweł Hajdan Jr., 2016-05-30 08:38:20]

I think it'd be safer to only have steps like this on Google-internal bots.
WDYT?

[Yoshisato Yanagisawa, 2016-05-30 09:06:08]

I guess there are trade offs.  It may reduce the risk to leak sensitive
information but it may increase the risk of rolling broken client?

Is it easy for internal bots to use the same recipes used by chromium buildbot? 
If not, we may test our client with recipes that does not reflect current way of
building chromium, and we may miss critical issues that break builds with recent
recipes.

I also guess that the size of reward to move all of such to internal might be
much smaller than size of the task.

[Yoshisato Yanagisawa, 2016-05-31 04:21:01]

By the way, do you know what is shown with current diagnose_goma?
I think output of diagnose_goma only shows harmless information now, and people
who want to know details need to use the webapp or download the log.

Or, do you see information you want to hide?

[Yoshisato Yanagisawa, 2016-06-08 02:10:17]

By the way, what is needed to move this change list forward?

If you think this revert incorrect in non-code-level point of view, we should
need wide discussion instead of doing that in code review tool.  What do you
think?

[Paweł Hajdan Jr., 2016-06-08 09:37:35]

On 2016/06/08 at 02:10:17, yyanagisawa wrote:
> By the way, what is needed to move this change list forward?
> 
> If you think this revert incorrect in non-code-level point of view, we should
need wide discussion instead of doing that in code review tool.  What do you
think?

Yes I think a discussion on internal ML or public infra-dev would be good.

[Yoshisato Yanagisawa, 2016-06-16 04:44:13]

close this issue until we reaches consensus on the issue, and the feature needed
to realize it is implemented.

[Yoshisato Yanagisawa, 2016-06-16 04:44:24]

Description was changed from

==========
Revert "build: remove diagnose_goma step to stop leaks"

This reverts commit 76cb0afec1641517e990d9595c84088b4c6e64eb.

BUG=chromium:605440
==========

to

==========
Revert "build: remove diagnose_goma step to stop leaks"

This reverts commit 76cb0afec1641517e990d9595c84088b4c6e64eb.

BUG=chromium:605440
==========