Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: scripts/slave/recipes/chromium.py

Issue 2020603002: Revert "build: remove diagnose_goma step to stop leaks" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index 07075b5cc6e45ca99e98a07450138e8b4d714b7c..e442d36541b7523ed59c9a89db95efb5e64d88f9 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -759,6 +759,14 @@ def GenTests(api):
)
yield (
+ api.test('goma_with_diagnose_goma_failure') +
+ api.properties.generic(mastername='chromium.fyi',
+ buildername='CrWinGoma',
+ build_data_dir='E:\\chrome-infra-logs') +
+ api.step_data('diagnose_goma', retcode=1)
+ )
+
+ yield (
api.test('dynamic_gtest_on_builder') +
api.properties.generic(mastername='chromium.linux',
buildername='Linux Builder') +

Powered by Google App Engine
This is Rietveld 408576698