Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2020603002: Revert "build: remove diagnose_goma step to stop leaks" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipes/chromium.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 import string 6 import string
7 7
8 8
9 class Test(object): 9 class Test(object):
10 """ 10 """
(...skipping 1816 matching lines...) Expand 10 before | Expand all | Expand 10 after
1827 @staticmethod 1827 @staticmethod
1828 def compile_targets(api): 1828 def compile_targets(api):
1829 return ['system_webview_apk'] 1829 return ['system_webview_apk']
1830 1830
1831 def run(self, api, suffix, test_filter=None): 1831 def run(self, api, suffix, test_filter=None):
1832 api.chromium_android.adb_install_apk( 1832 api.chromium_android.adb_install_apk(
1833 api.chromium_android.apk_path('SystemWebView.apk')) 1833 api.chromium_android.apk_path('SystemWebView.apk'))
1834 api.chromium_android.run_webview_cts() 1834 api.chromium_android.run_webview_cts()
1835 1835
1836 1836
1837 class DiagnoseGomaTest(Test):
1838 name = 'diagnose_goma'
1839
1840 @property
1841 def name(self):
1842 return 'diagnose_goma'
1843
1844 @staticmethod
1845 def compile_targets(_):
1846 return []
1847
1848 def run(self, api, suffix, test_filter=None):
1849 diagnose_goma_log_py = api.path['build'].join('goma',
1850 'diagnose_goma_log.py')
1851 api.python('diagnose_goma', diagnose_goma_log_py, [])
1852
1853
1837 class IncrementalCoverageTest(Test): 1854 class IncrementalCoverageTest(Test):
1838 name = 'incremental_coverage' 1855 name = 'incremental_coverage'
1839 1856
1840 @property 1857 @property
1841 def uses_local_devices(self): 1858 def uses_local_devices(self):
1842 return True 1859 return True
1843 1860
1844 def has_valid_results(self, api, suffix): 1861 def has_valid_results(self, api, suffix):
1845 return True 1862 return True
1846 1863
(...skipping 13 matching lines...) Expand all
1860 def run(self, api, suffix, test_filter=None): 1877 def run(self, api, suffix, test_filter=None):
1861 api.chromium_android.coverage_report(upload=False) 1878 api.chromium_android.coverage_report(upload=False)
1862 api.chromium_android.get_changed_lines_for_revision() 1879 api.chromium_android.get_changed_lines_for_revision()
1863 api.chromium_android.incremental_coverage_report() 1880 api.chromium_android.incremental_coverage_report()
1864 1881
1865 1882
1866 GOMA_TESTS = [ 1883 GOMA_TESTS = [
1867 GTestTest('base_unittests'), 1884 GTestTest('base_unittests'),
1868 GTestTest('content_unittests'), 1885 GTestTest('content_unittests'),
1869 ] 1886 ]
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipes/chromium.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698