Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2020323004: [turbofan] Remove eager frame state from all nodes. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from all nodes. This completely removes the ability from nodes to point directly to the frame state representing their eager bailout point. All nodes now either have zero or one frame state inputs. These frame states can by now be found via checkpoints in the graph. R=bmeurer@chromium.org BUG=v8:5021 Committed: https://crrev.com/cc1e84b96c1d6d66b70373a5182b876cf5a880ac Cr-Commit-Position: refs/heads/master@{#38282}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -208 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 3 7 chunks +14 lines, -25 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 5 chunks +11 lines, -20 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/escape-analysis.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 3 19 chunks +29 lines, -32 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 8 chunks +15 lines, -89 lines 0 comments Download
M src/compiler/node-properties.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/node-properties.cc View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/operator-properties.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-03 08:45:29 UTC) #5
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-03 08:55:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2020323004/60001
4 years, 4 months ago (2016-08-03 10:07:21 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-03 10:38:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 10:39:24 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cc1e84b96c1d6d66b70373a5182b876cf5a880ac
Cr-Commit-Position: refs/heads/master@{#38282}

Powered by Google App Engine
This is Rietveld 408576698