Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2205243002: [turbofan] Remove deprecated FrameStateBeforeAndAfter. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove deprecated FrameStateBeforeAndAfter. The helper class in question is no longer needed now that frame states representing the "before" state is not attached to nodes anymore. They are represented by appropriate {Checkpoint} nodes in the graph now. R=bmeurer@chromium.org BUG=v8:5021 Committed: https://crrev.com/fa1fd5a60088f091c6ec3ce8702e5f004d678392 Cr-Commit-Position: refs/heads/master@{#38288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -56 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +8 lines, -55 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-03 10:17:45 UTC) #3
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-03 12:12:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205243002/1
4 years, 4 months ago (2016-08-03 12:12:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 12:14:15 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 12:14:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1fd5a60088f091c6ec3ce8702e5f004d678392
Cr-Commit-Position: refs/heads/master@{#38288}

Powered by Google App Engine
This is Rietveld 408576698