Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4505)

Unified Diff: chrome/browser/android/preferences/website_preference_bridge.cc

Issue 2020063003: Use GetPermissionStatus instead of DesktopNotificationProfileUtil::GetContentSetting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change GetNotificationOrigin to use GetSettingForOrigin on Android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/service_worker_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/preferences/website_preference_bridge.cc
diff --git a/chrome/browser/android/preferences/website_preference_bridge.cc b/chrome/browser/android/preferences/website_preference_bridge.cc
index 62f8784ad826e58770d414d87097f71c5e294a26..d435c71a2f1009e1f0618042a2143c2c3a5ad440 100644
--- a/chrome/browser/android/preferences/website_preference_bridge.cc
+++ b/chrome/browser/android/preferences/website_preference_bridge.cc
@@ -315,9 +315,8 @@ static jint GetNotificationSettingForOrigin(
const JavaParamRef<jstring>& origin,
const JavaParamRef<jstring>& embedder,
jboolean is_incognito) {
- return DesktopNotificationProfileUtil::GetContentSetting(
- GetActiveUserProfile(is_incognito),
- GURL(ConvertJavaStringToUTF8(env, origin)));
+ return GetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+ origin, origin, is_incognito);
Bernhard Bauer 2016/06/02 11:19:01 Is it on purpose that we ignore the embedder and u
Michael van Ouwerkerk 2016/06/02 12:03:01 Yes, that's on purpose: https://codereview.chromiu
lshang 2016/06/02 12:05:25 I use origins for both params here mainly because
Bernhard Bauer 2016/06/02 12:23:04 Why don't we get rid of the parameter then?
}
static void SetNotificationSettingForOrigin(
« no previous file with comments | « no previous file | chrome/browser/extensions/service_worker_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698