Use GetPermissionStatus instead of DesktopNotificationProfileUtil::GetContentSetting

chrome/browser/android/preferences/website_preference_bridge.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/preferences/website_preference_bridge.h"
 
 #include "base/android/callback_android.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 297 matching lines @@
              &Java_WebsitePreferenceBridge_insertNotificationIntoList, list,
              false);
 }
 
 static jint GetNotificationSettingForOrigin(
     JNIEnv* env,
     const JavaParamRef<jclass>& clazz,
     const JavaParamRef<jstring>& origin,
     const JavaParamRef<jstring>& embedder,
     jboolean is_incognito) {
-  return DesktopNotificationProfileUtil::GetContentSetting(
-      GetActiveUserProfile(is_incognito),
-      GURL(ConvertJavaStringToUTF8(env, origin)));
+  return GetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                             origin, origin, is_incognito);

[Bernhard Bauer, 2016/06/02 11:19:01]

Is it on purpose that we ignore the embedder and use the origin instead?

[Michael van Ouwerkerk, 2016/06/02 12:03:01]

Yes, that's on purpose: https://codereview.chromium.org/921803002/

[lshang, 2016/06/02 12:05:25]

I use origins for both params here mainly because the previous code
DesktopNotificationProfileUtil::GetContentSetting() only uses origins, and I'm
making them consistent before and after the migration to introduce bugs. 

On more thoughts, CONTENT_SETTINGS_TYPE_NOTIFICATIONS is
REQUESTING_ORIGIN_ONLY_SCOPE, and it only uses origin when setting content
settings. So I think notifications only cares about origin.

[Bernhard Bauer, 2016/06/02 12:23:04]

Why don't we get rid of the parameter then?

 }
 
 static void SetNotificationSettingForOrigin(
     JNIEnv* env,
     const JavaParamRef<jclass>& clazz,
     const JavaParamRef<jstring>& origin,
     const JavaParamRef<jstring>& embedder,
     jint value,
     jboolean is_incognito) {
   // Note: Web Notification permission behaves differently from all other
@@ skipping 360 matching lines @@
   GURL url(ConvertJavaStringToUTF8(env, jorigin));
   scoped_refptr<SiteDataDeleteHelper> site_data_deleter(
       new SiteDataDeleteHelper(profile, url));
   site_data_deleter->Run();
 }
 
 // Register native methods
 bool RegisterWebsitePreferenceBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }