Enable Notification permissions to be toggled in Site Settings.

Enable Notification permissions to be toggled in Site Settings.

Web Notifications content settings don't consider the embedding origin
in the same way other origins do, but we're expecting this to happen when
updating the content setting values. Rather, defer to the
DesktopNotificationProfileUtil methods, which currently group this
non-standard behavior together.

BUG=458143
Committed: https://crrev.com/5b582647a39f5d6806709fdeb28d3c709bc61471
Cr-Commit-Position: refs/heads/master@{#316036}

[Peter Beverloo, 2015-02-12 16:32:27]

peter@chromium.org changed reviewers:
+ finnur@chromium.org, miguelg@chromium.org

[Peter Beverloo, 2015-02-12 16:32:28]

+finnur for the settings bridge
+miguelg for OWNERS

[Miguel Garcia, 2015-02-12 16:55:27]

lgtm

Not pretty but until we fix the odd notification behavior I guess this is as
good as it's going to get.

[Miguel Garcia, 2015-02-12 19:47:27]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2015-02-12 19:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921803002/1

[commit-bot: I haz the power, 2015-02-12 20:07:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-12 20:08:04]

Patchset 1 (id:??) landed as
https://crrev.com/5b582647a39f5d6806709fdeb28d3c709bc61471
Cr-Commit-Position: refs/heads/master@{#316036}

[Finnur, 2015-02-13 14:58:46]

https://codereview.chromium.org/921803002/diff/1/chrome/browser/android/prefe...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/921803002/diff/1/chrome/browser/android/prefe...
chrome/browser/android/preferences/website_preference_bridge.cc:219: }
I was going to point out that this breaks the Site Settings page (the part that
lists all origins with this permission), but upon closer inspection it looks
like GrantPermission populates the host content settings map as we were doing. I
suppose you did an end-to-end test on this already?

[Peter Beverloo, 2015-02-13 15:01:20]

On 2015/02/13 14:58:46, Finnur wrote:
>
https://codereview.chromium.org/921803002/diff/1/chrome/browser/android/prefe...
> File chrome/browser/android/preferences/website_preference_bridge.cc (right):
> 
>
https://codereview.chromium.org/921803002/diff/1/chrome/browser/android/prefe...
> chrome/browser/android/preferences/website_preference_bridge.cc:219: }
> I was going to point out that this breaks the Site Settings page (the part
that
> lists all origins with this permission), but upon closer inspection it looks
> like GrantPermission populates the host content settings map as we were doing.
I
> suppose you did an end-to-end test on this already?

Yes. Miguel found a crash about an invalid content settings pattern before this
CL, but I haven't been able to reproduce it with the CL.

[Finnur, 2015-02-13 15:16:19]

Fine. I was referring to the ability of the UI to continue listing the push
notification sites that specify a allow/deny value, but I think we're on the
same page.

LGTM.