Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019723002: Subclass GrVkCommandBuffer into Primary and Secondary CommandBuffers. (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@renderPass2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Subclass GrVkCommandBuffer into Primary and Secondary CommandBuffers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2019723002 Committed: https://skia.googlesource.com/skia/+/9a6cf800bc392fb4ba5065efb64f5b0320098d1a

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Add executeCommands impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -316 lines) Patch
M src/gpu/vk/GrVkCommandBuffer.h View 1 2 4 chunks +111 lines, -75 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.cpp View 1 2 13 chunks +306 lines, -228 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkRenderPass.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkRenderPass.cpp View 1 2 2 chunks +14 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
egdaniel
A lot of the changes shown by codereview are moving functions from the top level ...
4 years, 6 months ago (2016-05-31 15:36:47 UTC) #3
jvanverth1
lgtm + comment https://codereview.chromium.org/2019723002/diff/20001/src/gpu/vk/GrVkCommandBuffer.h File src/gpu/vk/GrVkCommandBuffer.h (right): https://codereview.chromium.org/2019723002/diff/20001/src/gpu/vk/GrVkCommandBuffer.h#newcode181 src/gpu/vk/GrVkCommandBuffer.h:181: void executeCommands(const GrVkGpu* gpu, Where is ...
4 years, 6 months ago (2016-06-01 14:10:46 UTC) #4
egdaniel
Added definition of executeCommands and a couple support functions. https://codereview.chromium.org/2019723002/diff/20001/src/gpu/vk/GrVkCommandBuffer.h File src/gpu/vk/GrVkCommandBuffer.h (right): https://codereview.chromium.org/2019723002/diff/20001/src/gpu/vk/GrVkCommandBuffer.h#newcode181 src/gpu/vk/GrVkCommandBuffer.h:181: ...
4 years, 6 months ago (2016-06-01 17:50:49 UTC) #5
egdaniel
are changes since l gtm okay?
4 years, 6 months ago (2016-06-06 20:25:28 UTC) #6
jvanverth1
On 2016/06/06 20:25:28, egdaniel wrote: > are changes since l gtm okay? Yes, lgtm
4 years, 6 months ago (2016-06-06 20:35:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019723002/40001
4 years, 6 months ago (2016-06-08 15:09:10 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:22:10 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9a6cf800bc392fb4ba5065efb64f5b0320098d1a

Powered by Google App Engine
This is Rietveld 408576698