Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2018983002: [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@StringTrim
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. These builtins always call into C++ anyways and so there's no point in having the JavaScript wrapper around them, but instead they can be implemented as C++ builtins directly. R=franzih@chromium.org BUG=v8:5049 Committed: https://crrev.com/4e66888869bf04c73b41e5747e4595747a7b20df Cr-Commit-Position: refs/heads/master@{#36569}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -336 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/i18n.js View 5 chunks +8 lines, -5 lines 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -36 lines 0 comments Download
M src/objects.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +300 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -292 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Benedikt Meurer
4 years, 6 months ago (2016-05-27 12:47:37 UTC) #1
Benedikt Meurer
Hey Franziska, And another one for string.js. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-05-27 12:48:16 UTC) #2
Franzi
lgtm
4 years, 6 months ago (2016-05-29 05:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018983002/1
4 years, 6 months ago (2016-05-30 03:39:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/2353) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-05-30 03:40:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018983002/20001
4 years, 6 months ago (2016-05-30 03:54:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 04:21:28 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4e66888869bf04c73b41e5747e4595747a7b20df Cr-Commit-Position: refs/heads/master@{#36569}
4 years, 6 months ago (2016-05-30 04:22:40 UTC) #13
Michael Achenbach
4 years, 6 months ago (2016-05-30 07:01:29 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2023753002/ by machenbach@chromium.org.

The reason for reverting is: Please rebase blink first (if intended):
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

Powered by Google App Engine
This is Rietveld 408576698