Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2018753003: Moves ash/wm/common back into ash (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook, reveman, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org, dcheng, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ash/wm/common back into ash As ash/wm/common is going to use the rest of ash it doesn't make sense to have a separate component. BUG=none TEST=covered by tests R=jamescook@chromium.org TBR=reveman@chromium.org,kelvinp@chromium.org Committed: https://crrev.com/bedda6175c6477948f5bc43d608a713cece15f38 Cr-Commit-Position: refs/heads/master@{#396577}

Patch Set 1 #

Patch Set 2 : nuke export #

Total comments: 4

Patch Set 3 : merge #

Patch Set 4 : review #

Patch Set 5 : remove BUILD.gn again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -306 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash.gyp View 1 2 5 chunks +90 lines, -4 lines 0 comments Download
D ash/wm/common/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -140 lines 0 comments Download
M ash/wm/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/common/always_on_top_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/ash_wm_common_export.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
M ash/wm/common/background_animator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/container_finder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/common/default_window_resizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/dock/docked_window_layout_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/dock/docked_window_layout_manager_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/dock/docked_window_resizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/drag_details.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/fullscreen_window_finder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/panels/panel_layout_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/panels/panel_window_resizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/root_window_finder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf_constants.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/switchable_windows.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/common/window_positioner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/window_positioning_utils.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/common/window_resizer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/window_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/window_state_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/window_state_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/window_state_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/wm_activation_observer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_display_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_event.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/wm_globals.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_layout_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_lookup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_overview_mode_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_root_window_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_root_window_controller_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_screen_util.h View 2 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/common/wm_snap_to_pixel_layout_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_toplevel_window_event_handler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/common/wm_types.h View 2 chunks +4 lines, -7 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_window_observer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/magnetism_matcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/multi_window_resize_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/phantom_window_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/two_step_edge_cycler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager_backdrop_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/exo.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
sky
4 years, 6 months ago (2016-05-27 00:01:24 UTC) #2
sky
I'm going to move the resources separately.
4 years, 6 months ago (2016-05-27 00:01:38 UTC) #3
James Cook
LGTM https://codereview.chromium.org/2018753003/diff/20001/mash/wm/BUILD.gn File mash/wm/BUILD.gn (right): https://codereview.chromium.org/2018753003/diff/20001/mash/wm/BUILD.gn#newcode84 mash/wm/BUILD.gn:84: "//ash:ash", Do we prefer //ash:ash or just //ash ...
4 years, 6 months ago (2016-05-27 16:09:09 UTC) #4
sky
https://codereview.chromium.org/2018753003/diff/20001/mash/wm/BUILD.gn File mash/wm/BUILD.gn (right): https://codereview.chromium.org/2018753003/diff/20001/mash/wm/BUILD.gn#newcode84 mash/wm/BUILD.gn:84: "//ash:ash", On 2016/05/27 16:09:09, James Cook wrote: > Do ...
4 years, 6 months ago (2016-05-27 19:19:53 UTC) #7
sky
TBR reveman@chromium.org,kelvinp@chromium.org and gn changes.
4 years, 6 months ago (2016-05-27 19:20:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018753003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018753003/80001
4 years, 6 months ago (2016-05-27 19:20:33 UTC) #11
reveman
lgtm
4 years, 6 months ago (2016-05-27 20:23:31 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-05-27 21:57:30 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:59:31 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bedda6175c6477948f5bc43d608a713cece15f38
Cr-Commit-Position: refs/heads/master@{#396577}

Powered by Google App Engine
This is Rietveld 408576698