tools/gyp/configurations_android.gypi - Issue 2018723002: Make Android gyp flags more like Linux gyp flags. Fix cases of -Wconversion-null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/configurations_android.gypi

Issue 2018723002: Make Android gyp flags more like Linux gyp flags. Fix cases of -Wconversion-null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/configurations_android.gypi

diff --git a/tools/gyp/configurations_android.gypi b/tools/gyp/configurations_android.gypi

index 8708d6dafadbd9cbf9a1333c76f85fb3132190ec..2aa561bb772ab866a1c3e6c80b7e35fc6fd5d6bf 100644

--- a/tools/gyp/configurations_android.gypi

+++ b/tools/gyp/configurations_android.gypi

@@ -19,8 +19,17 @@

# order.

'Dart_Android_Base': {

'abstract': 1,

- 'cflags': [ '-Wno-abi', '-Wall', '-W', '-Wno-unused-parameter',

- '-Wnon-virtual-dtor', '-fno-rtti', '-fno-exceptions',],

+ 'cflags': [

+ # No -Werror due to warnings in stl.

+ '<@(common_gcc_warning_flags)',

+ '-Wnon-virtual-dtor',

+ '-Wvla',

+ '-Woverloaded-virtual',

+ '-g3',

+ '-ggdb3',

+ '-fno-rtti',

+ '-fno-exceptions',

+ ],

'target_conditions': [

['_toolset=="target"', {

'defines': [

« no previous file with comments | « runtime/vm/unit_test.cc ('k') | tools/gyp/configurations_make.gypi » ('j') | no next file with comments »