tools/gyp/configurations_make.gypi - Issue 2018723002: Make Android gyp flags more like Linux gyp flags. Fix cases of -Wconversion-null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/configurations_make.gypi

Issue 2018723002: Make Android gyp flags more like Linux gyp flags. Fix cases of -Wconversion-null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/configurations_make.gypi

diff --git a/tools/gyp/configurations_make.gypi b/tools/gyp/configurations_make.gypi

index 05292bfefb868892d9ec9c79886ff1c4835d3b12..8b61127b3d05317db42546b680a0a3a07ad51413 100644

--- a/tools/gyp/configurations_make.gypi

+++ b/tools/gyp/configurations_make.gypi

@@ -18,16 +18,11 @@

'<@(common_gcc_warning_flags)',

'-Wnon-virtual-dtor',

'-Wvla',

- '-Wno-conversion-null',

'-Woverloaded-virtual',

'-g3',

'-ggdb3',

- # TODO(iposva): Figure out if we need to pass anything else.

- #'-ansi',

'-fno-rtti',

'-fno-exceptions',

- # '-fvisibility=hidden',

- # '-fvisibility-inlines-hidden',

'-fstack-protector',

'-Wa,--noexecstack',

« no previous file with comments | « tools/gyp/configurations_android.gypi ('k') | no next file » | no next file with comments »