Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: tools/gyp/configurations_android.gypi

Issue 2018723002: Make Android gyp flags more like Linux gyp flags. Fix cases of -Wconversion-null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/unit_test.cc ('k') | tools/gyp/configurations_make.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 # Definitions for building standalone Dart binaries to run on Android. 5 # Definitions for building standalone Dart binaries to run on Android.
6 # This is mostly excerpted from: 6 # This is mostly excerpted from:
7 # http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi 7 # http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi
8 8
9 { 9 {
10 'variables': { 10 'variables': {
11 'android_ndk_root': '<(PRODUCT_DIR)/../../third_party/android_tools/ndk', 11 'android_ndk_root': '<(PRODUCT_DIR)/../../third_party/android_tools/ndk',
12 }, # variables 12 }, # variables
13 'target_defaults': { 13 'target_defaults': {
14 'configurations': { 14 'configurations': {
15 # It is very important to get the order of the linker arguments correct. 15 # It is very important to get the order of the linker arguments correct.
16 # Therefore, we put them all in the architecture specific configurations, 16 # Therefore, we put them all in the architecture specific configurations,
17 # even though there are many flags in common, to avoid splitting them 17 # even though there are many flags in common, to avoid splitting them
18 # between two configurations and possibly accidentally mixing up the 18 # between two configurations and possibly accidentally mixing up the
19 # order. 19 # order.
20 'Dart_Android_Base': { 20 'Dart_Android_Base': {
21 'abstract': 1, 21 'abstract': 1,
22 'cflags': [ '-Wno-abi', '-Wall', '-W', '-Wno-unused-parameter', 22 'cflags': [
23 '-Wnon-virtual-dtor', '-fno-rtti', '-fno-exceptions',], 23 # No -Werror due to warnings in stl.
24 '<@(common_gcc_warning_flags)',
25 '-Wnon-virtual-dtor',
26 '-Wvla',
27 '-Woverloaded-virtual',
28 '-g3',
29 '-ggdb3',
30 '-fno-rtti',
31 '-fno-exceptions',
32 ],
24 'target_conditions': [ 33 'target_conditions': [
25 ['_toolset=="target"', { 34 ['_toolset=="target"', {
26 'defines': [ 35 'defines': [
27 'ANDROID', 36 'ANDROID',
28 'USE_STLPORT=1', 37 'USE_STLPORT=1',
29 '__GNU_SOURCE=1', 38 '__GNU_SOURCE=1',
30 '_STLP_USE_PTR_SPECIALIZATIONS=1', 39 '_STLP_USE_PTR_SPECIALIZATIONS=1',
31 'HAVE_OFF64_T', 40 'HAVE_OFF64_T',
32 'HAVE_SYS_UIO_H', 41 'HAVE_SYS_UIO_H',
33 ], 42 ],
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 ], 314 ],
306 }], 315 }],
307 ['_toolset=="host"', { 316 ['_toolset=="host"', {
308 'ldflags': [ '-pthread' ], 317 'ldflags': [ '-pthread' ],
309 }], 318 }],
310 ], 319 ],
311 }, # Dart_Android_arm64_Base 320 }, # Dart_Android_arm64_Base
312 }, # configurations 321 }, # configurations
313 }, # target_defaults 322 }, # target_defaults
314 } 323 }
OLDNEW
« no previous file with comments | « runtime/vm/unit_test.cc ('k') | tools/gyp/configurations_make.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698