Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2011763007: Revert of 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
jbudorick, mef, Nico
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, michaelbai, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset #17 id:320001 of https://codereview.chromium.org/1926793002/ ) Reason for revert: Broke webview tests: https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/9501 Original issue's description: > Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root > > And use delete_device_stale=True when pushing. This will prevent tests > mistakenly passing when they depend on stale data files from a previous test. > > BUG=607169 > > Committed: https://crrev.com/0fe567512193cc8fbfcfd006ff1d504bd6346290 > Cr-Commit-Position: refs/heads/master@{#396169} TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607169 Committed: https://crrev.com/5a7a6cd176bd3c1a9524893801b8d177ebe0f63a Cr-Commit-Position: refs/heads/master@{#396174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -131 lines) Patch
M base/base_paths_android.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java View 2 chunks +2 lines, -9 lines 0 comments Download
M base/test/test_support_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M base/test/test_support_android.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +3 lines, -7 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +6 lines, -12 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/apk_test.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/test/mock_cert_verifier.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 2 chunks +1 line, -8 lines 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 5 chunks +6 lines, -12 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/NativeTestServer.java View 3 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 3 chunks +2 lines, -4 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java View 2 chunks +9 lines, -8 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java View 3 chunks +2 lines, -3 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/CertTestUtil.java View 2 chunks +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.cc View 2 chunks +1 line, -7 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 3 chunks +2 lines, -3 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
Created Revert of 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata
4 years, 7 months ago (2016-05-26 14:52:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011763007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011763007/1
4 years, 7 months ago (2016-05-26 14:52:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 14:53:39 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a7a6cd176bd3c1a9524893801b8d177ebe0f63a Cr-Commit-Position: refs/heads/master@{#396174}
4 years, 7 months ago (2016-05-26 14:54:52 UTC) #6
agrieve
4 years, 6 months ago (2016-05-26 20:45:13 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2018663002/ by agrieve@chromium.org.

The reason for reverting is: will update once fixed..

Powered by Google App Engine
This is Rietveld 408576698