Issue 201843003: Robustified address calculations on A64.

Issue 201843003: Robustified address calculations on A64. (Closed)

Created:
6 years, 9 months ago by Sven Panne

Modified:
6 years, 9 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM), Rodolph Perfetta

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Robustified address calculations on A64. We no longer rely on the (adventurous) assumption that the class Instruction is empty, implying sizeof(Instruction) == 1. This will greatly simplify upcoming refactorings. R=rodolph.perfetta@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=20018

Patch Set 1 #

Patch Set 2 : Tiny cleanup. Rebased. #

Total comments: 4

Patch Set 3 : Feedback. Rebased. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -41 lines)			Patch
M	src/a64/disasm-a64.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/a64/instructions-a64.h	View		2 chunks	+17 lines, -12 lines	0 comments	Download
M	src/a64/instructions-a64.cc	View	1 2	4 chunks	+7 lines, -8 lines	0 comments	Download
M	src/a64/macro-assembler-a64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/a64/simulator-a64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/a64/simulator-a64.cc	View		7 chunks	+19 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

First baby steps towards cleaning up the int32_t/Instr/Instruction/InstructionSequence mess.

6 years, 9 months ago (2014-03-17 14:44:51 UTC) #1

Rodolph Perfetta

very minor nits otherwise LGTM. https://codereview.chromium.org/201843003/diff/20001/src/a64/instructions-a64.cc File src/a64/instructions-a64.cc (right): https://codereview.chromium.org/201843003/diff/20001/src/a64/instructions-a64.cc#newcode266 src/a64/instructions-a64.cc:266: ASSERT((DistanceTo(target) & 3) == ...

6 years, 9 months ago (2014-03-17 15:23:21 UTC) #3

Sven Panne

Feedback addressed, landing... https://codereview.chromium.org/201843003/diff/20001/src/a64/instructions-a64.cc File src/a64/instructions-a64.cc (right): https://codereview.chromium.org/201843003/diff/20001/src/a64/instructions-a64.cc#newcode266 src/a64/instructions-a64.cc:266: ASSERT((DistanceTo(target) & 3) == 0); On ...

6 years, 9 months ago (2014-03-18 07:13:20 UTC) #4

Sven Panne

6 years, 9 months ago (2014-03-18 07:14:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20018 (presubmit successful).

Expand Messages | Collapse Messages