Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2018353004: [turbofan] Remove eager frame state from runtime calls. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from runtime calls. This removes the frame state input representing the before-state from nodes having the {JSCallRuntime} operator. These frame states can by now be found via checkpoints in the graph. It also makes the predicate for runtime function ids (i.e. {Linkage::NeedsFrameStateInput}) binary. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/a7ff61654a25cbee386de933ff15b1adeb49fc3c Cr-Commit-Position: refs/heads/master@{#36679}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Small fix. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 6 months ago (2016-05-30 12:59:50 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-05-30 13:13:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018353004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018353004/60001
4 years, 6 months ago (2016-06-02 10:40:44 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-02 10:42:48 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 10:45:44 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a7ff61654a25cbee386de933ff15b1adeb49fc3c
Cr-Commit-Position: refs/heads/master@{#36679}

Powered by Google App Engine
This is Rietveld 408576698