Issue 201773005: Copy a few selection related methods to WebFrame from WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201773005: Copy a few selection related methods to WebFrame from WebView. (Closed)

Created:
6 years, 9 months ago by jam

Modified:
6 years, 9 months ago

Reviewers:
dglazkov

CC:
blink-reviews, jamesr, abarth-chromium, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Copy a few selection related methods to WebFrame from WebView. The old methods are temporarily left on WebView until Chrome switches. Also remove WebView::isSelectionEditable since it's not called. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169968

Patch Set 1 #

Patch Set 2 : update test #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -32 lines)			Patch
M	Source/web/WebFrameImpl.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View		3 chunks	+39 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/web/tests/WebViewTest.cpp	View	1	15 chunks	+29 lines, -22 lines	0 comments	Download
M	public/web/WebFrame.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	public/web/WebView.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/201773005/20001

6 years, 9 months ago (2014-03-25 16:56:12 UTC) #6

Message was sent while issue was closed.

Change committed as 169968

Expand Messages | Collapse Messages