Source/web/WebViewImpl.cpp - Issue 201773005: Copy a few selection related methods to WebFrame from WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 201773005: Copy a few selection related methods to WebFrame from WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 29bedfed385f4fade1598571b65a6635de499ce3..a13a00c1f5328cf08572e2cc2291c1776e3e1df8 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2290,13 +2290,6 @@ void WebViewImpl::extendSelectionAndDelete(int before, int after)

focused->inputMethodController().extendSelectionAndDelete(before, after);

}

-bool WebViewImpl::isSelectionEditable() const

- if (const LocalFrame* frame = focusedWebCoreFrame())

- return frame->selection().isContentEditable();

- return false;

WebColor WebViewImpl::backgroundColor() const

{

if (isTransparent())

« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »