Source/web/WebViewImpl.h - Issue 201773005: Copy a few selection related methods to WebFrame from WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 201773005: Copy a few selection related methods to WebFrame from WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 2bb2c378a94f8a0e6d51d214d7bab5c80979fc49..401e01c04701974f86f00f8b0b27f148a33568d2 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -153,7 +153,6 @@ public:

virtual bool setEditableSelectionOffsets(int start, int end) OVERRIDE;

virtual bool setCompositionFromExistingText(int compositionStart, int compositionEnd, const WebVector<WebCompositionUnderline>& underlines) OVERRIDE;

virtual void extendSelectionAndDelete(int before, int after) OVERRIDE;

- virtual bool isSelectionEditable() const OVERRIDE;

virtual WebColor backgroundColor() const OVERRIDE;

virtual bool selectionBounds(WebRect& anchor, WebRect& focus) const OVERRIDE;

virtual void didShowCandidateWindow() OVERRIDE;

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »