third_party/WebKit/Source/core/page/FrameTree.cpp - Issue 2017053003: Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/FrameTree.cpp

diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp

index c218e8b0f95a0bb7b3a1206b5158dc434674bcae..daf5e21122a9d7d687be5952266f193635bb8e10 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.cpp

+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp

@@ -179,9 +179,9 @@ AtomicString FrameTree::calculateUniqueNameForChildFrame(

uniqueName.append(frame->tree().uniqueName());

}

- uniqueName.appendLiteral("/<!--frame");

+ uniqueName.append("/<!--frame");

uniqueName.appendNumber(childCount() - (existingChildFrame ? 1 : 0));

- uniqueName.appendLiteral("-->-->");

+ uniqueName.append("-->-->");

return uniqueName.toAtomicString();

}