Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/core/page/EventSource.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/EventSource.cpp
diff --git a/third_party/WebKit/Source/core/page/EventSource.cpp b/third_party/WebKit/Source/core/page/EventSource.cpp
index 1c6b1be6a8902772c484152ebf8fae4ab29a781c..dfa1f8289d154986d315a5abf99f78602dc7ea0c 100644
--- a/third_party/WebKit/Source/core/page/EventSource.cpp
+++ b/third_party/WebKit/Source/core/page/EventSource.cpp
@@ -238,9 +238,9 @@ void EventSource::didReceiveResponse(unsigned long, const ResourceResponse& resp
responseIsValid = charset.isEmpty() || equalIgnoringCase(charset, "UTF-8");
if (!responseIsValid) {
StringBuilder message;
- message.appendLiteral("EventSource's response has a charset (\"");
+ message.append("EventSource's response has a charset (\"");
message.append(charset);
- message.appendLiteral("\") that is not UTF-8. Aborting the connection.");
+ message.append("\") that is not UTF-8. Aborting the connection.");
// FIXME: We are missing the source line.
getExecutionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message.toString()));
}
@@ -248,9 +248,9 @@ void EventSource::didReceiveResponse(unsigned long, const ResourceResponse& resp
// To keep the signal-to-noise ratio low, we only log 200-response with an invalid MIME type.
if (statusCode == 200 && !mimeTypeIsValid) {
StringBuilder message;
- message.appendLiteral("EventSource's response has a MIME type (\"");
+ message.append("EventSource's response has a MIME type (\"");
message.append(response.mimeType());
- message.appendLiteral("\") that is not \"text/event-stream\". Aborting the connection.");
+ message.append("\") that is not \"text/event-stream\". Aborting the connection.");
// FIXME: We are missing the source line.
getExecutionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message.toString()));
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698