Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 if (frame) { 172 if (frame) {
173 uniqueName.append(frame->tree().uniqueName().getString().substring(frame PathPrefixLength, 173 uniqueName.append(frame->tree().uniqueName().getString().substring(frame PathPrefixLength,
174 frame->tree().uniqueName().length() - framePathPrefixLength - frameP athSuffixLength)); 174 frame->tree().uniqueName().length() - framePathPrefixLength - frameP athSuffixLength));
175 } 175 }
176 for (int i = chain.size() - 1; i >= 0; --i) { 176 for (int i = chain.size() - 1; i >= 0; --i) {
177 frame = chain[i]; 177 frame = chain[i];
178 uniqueName.append('/'); 178 uniqueName.append('/');
179 uniqueName.append(frame->tree().uniqueName()); 179 uniqueName.append(frame->tree().uniqueName());
180 } 180 }
181 181
182 uniqueName.appendLiteral("/<!--frame"); 182 uniqueName.append("/<!--frame");
183 uniqueName.appendNumber(childCount() - (existingChildFrame ? 1 : 0)); 183 uniqueName.appendNumber(childCount() - (existingChildFrame ? 1 : 0));
184 uniqueName.appendLiteral("-->-->"); 184 uniqueName.append("-->-->");
185 185
186 return uniqueName.toAtomicString(); 186 return uniqueName.toAtomicString();
187 } 187 }
188 188
189 Frame* FrameTree::scopedChild(unsigned index) const 189 Frame* FrameTree::scopedChild(unsigned index) const
190 { 190 {
191 unsigned scopedIndex = 0; 191 unsigned scopedIndex = 0;
192 for (Frame* child = firstChild(); child; child = child->tree().nextSibling() ) { 192 for (Frame* child = firstChild(); child; child = child->tree().nextSibling() ) {
193 if (child->client()->inShadowTree()) 193 if (child->client()->inShadowTree())
194 continue; 194 continue;
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 { 422 {
423 if (!frame) { 423 if (!frame) {
424 printf("Null input frame\n"); 424 printf("Null input frame\n");
425 return; 425 return;
426 } 426 }
427 427
428 printFrames(frame->tree().top(), frame, 0); 428 printFrames(frame->tree().top(), frame, 0);
429 } 429 }
430 430
431 #endif 431 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698