Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2016953002: update-w3c-deps: Do not rewrite links to /resources and /common. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update-w3c-deps: Do not rewrite links to /resources and /common. CLs to update imported tests will follow. BUG=613408 Committed: https://crrev.com/f719daba1bae9dedfdd82cbfa06564ac6d78e4da Cr-Commit-Position: refs/heads/master@{#396350}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix a comment, fix python tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -156 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/GUM-deny.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 1 3 chunks +0 lines, -127 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 2 chunks +7 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (5 generated)
tkent
qyearsley@, jsbell@, would you review this please?
4 years, 7 months ago (2016-05-26 23:51:16 UTC) #3
qyearsley
Excellent :-) A couple little questions/comments. https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode43 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:43: for resource in ...
4 years, 7 months ago (2016-05-27 00:19:37 UTC) #4
tkent
I need to update Python tests. https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode43 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:43: for resource in ...
4 years, 7 months ago (2016-05-27 00:29:06 UTC) #5
tkent
I uploaded a new patch set. Please take another look.
4 years, 7 months ago (2016-05-27 00:37:35 UTC) #6
qyearsley
LGTM Note, there are now a lot of things to update when we updated imported ...
4 years, 7 months ago (2016-05-27 00:47:23 UTC) #7
tkent
My plan is: 1. Land this now. 2. Replace links in imported tests without running ...
4 years, 7 months ago (2016-05-27 00:56:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016953002/40001
4 years, 7 months ago (2016-05-27 01:51:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-27 01:56:44 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f719daba1bae9dedfdd82cbfa06564ac6d78e4da Cr-Commit-Position: refs/heads/master@{#396350}
4 years, 7 months ago (2016-05-27 01:58:16 UTC) #13
qyearsley
On 2016/05/27 at 00:56:07, tkent wrote: > My plan is: > 1. Land this now. ...
4 years, 6 months ago (2016-05-27 15:31:02 UTC) #14
Dirk Pranke
4 years, 6 months ago (2016-05-31 22:18:11 UTC) #16
Message was sent while issue was closed.
I defer to qyearsley here (sorry for the delay; the idea seems basically good,
but I didn't stare at the details of the code).

Powered by Google App Engine
This is Rietveld 408576698