update-w3c-deps: Do not rewrite links to /resources and /common.

update-w3c-deps: Do not rewrite links to /resources and /common.

CLs to update imported tests will follow.

BUG=613408
Committed: https://crrev.com/f719daba1bae9dedfdd82cbfa06564ac6d78e4da
Cr-Commit-Position: refs/heads/master@{#396350}

[tkent, 2016-05-26 23:48:57]

Patchset #1 (id:1) has been deleted

[tkent, 2016-05-26 23:51:15]

tkent@chromium.org changed reviewers:
+ jsbell@chromium.org, qyearsley@chromium.org

[tkent, 2016-05-26 23:51:16]

qyearsley@, jsbell@, would you review this please?

[qyearsley, 2016-05-27 00:19:37]

Excellent :-) A couple little questions/comments.

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:43: for resource
in ['testharnessreport.js', 'WebIDLParser.js']:
Has vendor-prefix.js been renamed to WebIDLParser.js?

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:33: - By default,
all tests are imported under LayoutTests/imported/[repo-name].
Technically, the default destination dir of import-w3c-deps is still w3c (set on
line 134 below), although when update-w3c-deps invokes import-w3c-deps it passes
the destination directory "imported".

Although, the default could be changed to "imported" below without breaking
anything I think. Or you could keep this comment the same for this CL.

In http://crrev.com//2012963002 I am proposing to remove this section of the
docstring since it doesn't seem important.

[tkent, 2016-05-27 00:29:06]

I need to update Python tests.

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:43: for resource
in ['testharnessreport.js', 'WebIDLParser.js']:
On 2016/05/27 at 00:19:36, qyearsley wrote:
> Has vendor-prefix.js been renamed to WebIDLParser.js?

No.
* We don't need to copy verndor-prefix.js because we have
imported/wpt/common/vendor-prefix.js
* We need to copy WebIDLParser.js because we don't have
imported/wpt/resources/WebIDLParser.js and some WPT tests assume
/resources/WebIDLParser.js is accessible.  wptserve has a special forwarding for
/resources/WebIDLParser.js.

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2016953002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:33: - By default,
all tests are imported under LayoutTests/imported/[repo-name].
On 2016/05/27 at 00:19:36, qyearsley wrote:
> Technically, the default destination dir of import-w3c-deps is still w3c (set
on line 134 below), although when update-w3c-deps invokes import-w3c-deps it
passes the destination directory "imported".
> 
> Although, the default could be changed to "imported" below without breaking
anything I think. Or you could keep this comment the same for this CL.
> 
> In http://crrev.com//2012963002 I am proposing to remove this section of the
docstring since it doesn't seem important.

ok, I'll revert to "w3c"

[tkent, 2016-05-27 00:37:35]

I uploaded a new patch set.  Please take another look.

[qyearsley, 2016-05-27 00:47:23]

LGTM

Note, there are now a lot of things to update when we updated imported tests
next.

I made a CL last week, but didn't get all of the new baselines that are
required: http://crrev.com/1999243002.

So, after this CL, you could make an import update CL as well, and you may have
to make a couple of the little changes that are made in
http://crrev.com/1999243002; or you could wait until http://crbug.com/1999243002
gets committed first, which may be next week.

[tkent, 2016-05-27 00:56:07]

My plan is:
 1. Land this now.
 2. Replace links in imported tests without running update-w3c-deps.

I can complete them today.

I updated WPT import yesterday (https://codereview.chromium.org/2015623004/). 
So I think https://codereview.chromium.org/1999243002 is not necessary any
longer.

[tkent, 2016-05-27 01:50:47]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-05-27 01:51:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016953002/40001

[commit-bot: I haz the power, 2016-05-27 01:56:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-27 01:58:15]

Description was changed from

==========
update-w3c-deps: Do not rewrite links to /resources and /common.

CLs to update imported tests will follow.

BUG=613408
==========

to

==========
update-w3c-deps: Do not rewrite links to /resources and /common.

CLs to update imported tests will follow.

BUG=613408

Committed: https://crrev.com/f719daba1bae9dedfdd82cbfa06564ac6d78e4da
Cr-Commit-Position: refs/heads/master@{#396350}
==========

[commit-bot: I haz the power, 2016-05-27 01:58:16]

Patchset 2 (id:??) landed as
https://crrev.com/f719daba1bae9dedfdd82cbfa06564ac6d78e4da
Cr-Commit-Position: refs/heads/master@{#396350}

[qyearsley, 2016-05-27 15:31:02]

On 2016/05/27 at 00:56:07, tkent wrote:
> My plan is:
>  1. Land this now.
>  2. Replace links in imported tests without running update-w3c-deps.
> 
> I can complete them today.
> 
> I updated WPT import yesterday (https://codereview.chromium.org/2015623004/). 
So I think https://codereview.chromium.org/1999243002 is not necessary any
longer.

Awesome, thanks!

[Dirk Pranke, 2016-05-31 22:18:11]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-31 22:18:11]

I defer to qyearsley here (sorry for the delay; the idea seems basically good,
but I didn't stare at the details of the code).