Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1699983002: Editing: Make |EditingState*| arguments of CompositeEditCommand::moveParagraph* mandatory. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Make |EditingState*| arguments of CompositeEditCommand::moveParagraph* mandatory. This CL doesn't introduce new ASSERT_NO_EDITING_ABORTs. This CL has no tests. We're not sure if this CL makes user-visible behavior changes. The purpose of this CL is to reduce ClusterFuzz crashes in the future. BUG=586846 Committed: https://crrev.com/fea3a369e7be4f4fb07f5c0518b4015612ecc22f Cr-Commit-Position: refs/heads/master@{#375500}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-02-16 00:07:33 UTC) #2
yosin_UTC9
lgtm
4 years, 10 months ago (2016-02-16 01:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699983002/1
4 years, 10 months ago (2016-02-16 01:21:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 01:26:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:51:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fea3a369e7be4f4fb07f5c0518b4015612ecc22f
Cr-Commit-Position: refs/heads/master@{#375500}

Powered by Google App Engine
This is Rietveld 408576698