third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py - Issue 2016953002: update-w3c-deps: Do not rewrite links to /resources and /common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

Issue 2016953002: update-w3c-deps: Do not rewrite links to /resources and /common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a comment, fix python tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

index 0bebc73a208bfc002690e71dac992a2fd0107612..01a6c6f2623aaf10249a6351643ce7d1fbb7b937 100755

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

@@ -150,21 +150,6 @@ class _W3CTestConverter(HTMLParser):

def convert_attributes_if_needed(self, tag, attrs):

converted = self.get_starttag_text()

- if tag in ('script', 'link'):

- target_attr = 'src'

- if tag != 'script':

- target_attr = 'href'

- for attr_name, attr_value in attrs:

- if attr_name == target_attr:

- new_path = re.sub('/resources/(?=testharness|idlharness|WebIDLParser)',

- self.resources_relpath + '/',

- attr_value)

- converted = re.sub(re.escape(attr_value), new_path, converted)

- new_path = re.sub('/common/vendor-prefix',

- self.resources_relpath + '/vendor-prefix',

- attr_value)

- converted = re.sub(re.escape(attr_value), new_path, converted)

for attr_name, attr_value in attrs:

if attr_name == 'style':

new_style = self.convert_style_data(attr_value)