Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2016943004:
DevTools: eliminate race condition in WI.StylesSourceMapping. (Closed)
|
Created:
4 years, 6 months ago by lushnikov Modified:
4 years, 5 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: eliminate race condition in WI.StylesSourceMapping.
If the style file was disposed, it should not do any other scheduled
actions.
BUG=608106
R=pfeldman
Committed: https://crrev.com/3e2695d9380a54e59770b10a35c0de88e0e2a78d
Cr-Commit-Position: refs/heads/master@{#402326}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (9 generated)
please, take a look
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016943004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
Description was changed from ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman ========== to ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman ==========
lushnikov@chromium.org changed reviewers: + dgozman@chromium.org - pfeldman@chromium.org
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman ========== to ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman ========== to ========== DevTools: eliminate race condition in WI.StylesSourceMapping. If the style file was disposed, it should not do any other scheduled actions. BUG=608106 R=pfeldman Committed: https://crrev.com/3e2695d9380a54e59770b10a35c0de88e0e2a78d Cr-Commit-Position: refs/heads/master@{#402326} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3e2695d9380a54e59770b10a35c0de88e0e2a78d Cr-Commit-Position: refs/heads/master@{#402326} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
