Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2016883003: Remove Quirks flag, limit server retries (Closed)

Created:
4 years, 6 months ago by Greg Levin
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Quirks flag, limit server retries BUG=598841 TEST=Check that disable-quirks-client is no longer on the experimental flags list. This removes the disable-quirks-client command line flag, and places a limit of 10 on the number of times (with exponential backoff) that Chrome OS will attempt to contact the Quirks server in one session. Committed: https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b Cr-Commit-Position: refs/heads/master@{#397704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -64 lines) Patch
M ash/display/display_color_manager_chromeos_unittest.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/quirks.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/quirks/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/quirks/quirks_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/quirks/quirks_manager.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D components/quirks/switches.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/quirks/switches.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Greg Levin
Please have a look!
4 years, 6 months ago (2016-05-27 13:53:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016883003/1
4 years, 6 months ago (2016-05-27 13:54:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 15:58:36 UTC) #6
oshima
lgtm
4 years, 6 months ago (2016-06-01 16:09:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016883003/1
4 years, 6 months ago (2016-06-01 23:14:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/231739)
4 years, 6 months ago (2016-06-02 03:01:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016883003/1
4 years, 6 months ago (2016-06-03 13:47:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 14:50:20 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 14:51:43 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b
Cr-Commit-Position: refs/heads/master@{#397704}

Powered by Google App Engine
This is Rietveld 408576698