Remove Quirks flag, limit server retries

components/quirks/quirks_client.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/quirks/quirks_client.h"
 
 #include "base/base64.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/strings/stringprintf.h"
 #include "base/task_runner_util.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/quirks/quirks_manager.h"
 #include "components/version_info/version_info.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace quirks {
 
 namespace {
 
 const char kQuirksUrlFormat[] =
     "https://chromeosquirksserver-pa.googleapis.com/v2/display/%s/clients"
     "/chromeos/M%d";
 
+const int kMaxServerFailures = 10;
+
 const net::BackoffEntry::Policy kDefaultBackoffPolicy = {
     1,                // Initial errors before applying backoff
     10000,            // 10 seconds.
     2,                // Factor by which the waiting time will be multiplied.
     0,                // Random fuzzing percentage.
     1000 * 3600 * 6,  // Max wait between requests = 6 hours.
     -1,               // Don't discard entry.
     true,             // Use initial delay after first error.
 };
 
@@ skipping 66 matching lines @@
           << ",  response_code=" << response_code
           << ",  server_error=" << server_error;
 
   if (response_code == net::HTTP_NOT_FOUND) {
     VLOG(1) << IdToFileName(product_id_) << " not found on Quirks server.";
     Shutdown(false);
     return;
   }
 
   if (server_error) {
+    if (backoff_entry_.failure_count() >= kMaxServerFailures) {
+      // After 10 retires (5+ hours), give up, and try again in a month.
+      VLOG(1) << "Too many retries; Quirks Client shutting down.";
+      Shutdown(false);
+      return;
+    }
     url_fetcher_.reset();
     Retry();
     return;
   }
 
   std::string response;
   url_fetcher_->GetResponseAsString(&response);
   VLOG(2) << "Quirks server response:\n" << response;
 
   // Parse response data and write to file on file thread.
@@ skipping 38 matching lines @@
 
   if (!base::Base64Decode(data64, data)) {
     VLOG(1) << "Failed to decode Base64 icc data";
     return false;
   }
 
   return true;
 }
 
 }  // namespace quirks