Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2016613002: Remove ProcessMemoryDump::AddHeapDump() (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ProcessMemoryDump::AddHeapDump() BUG=605822 Committed: https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902 Cr-Commit-Position: refs/heads/master@{#396666}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -48 lines) Patch
M base/trace_event/process_memory_dump.h View 1 chunk +0 lines, -8 lines 0 comments Download
M base/trace_event/process_memory_dump.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M base/trace_event/process_memory_dump_unittest.cc View 2 chunks +16 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/WebProcessMemoryDump.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
bashi
Hi primiano@, Does the change in unittests make sense to you?
4 years, 7 months ago (2016-05-26 05:52:03 UTC) #2
Primiano Tucci (use gerrit)
Oops forgot about this. sorry for the delay. Definitely, LGTM. Thanks for the cleanup.
4 years, 6 months ago (2016-05-27 17:26:39 UTC) #3
bashi
haraken-san, PTAL?
4 years, 6 months ago (2016-05-29 22:41:32 UTC) #5
haraken
LGTM
4 years, 6 months ago (2016-05-29 23:31:31 UTC) #6
bashi
Kent-san, could you review WebKit/public/platform? Comment update only.
4 years, 6 months ago (2016-05-29 23:39:30 UTC) #8
tkent
third_party/WebKit/public/ lgtm
4 years, 6 months ago (2016-05-29 23:41:51 UTC) #9
bashi
Thanks for quick reviews! After rebasing I noticed that I didn't need to ask review ...
4 years, 6 months ago (2016-05-29 23:47:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016613002/20001
4 years, 6 months ago (2016-05-29 23:47:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 01:52:09 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 01:53:10 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902
Cr-Commit-Position: refs/heads/master@{#396666}

Powered by Google App Engine
This is Rietveld 408576698