third_party/WebKit/Source/platform/WebProcessMemoryDump.h - Issue 2016613002: Remove ProcessMemoryDump::AddHeapDump()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/WebProcessMemoryDump.h

Issue 2016613002: Remove ProcessMemoryDump::AddHeapDump() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/process_memory_dump_unittest.cc ('k') | third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/WebProcessMemoryDump.h

diff --git a/third_party/WebKit/Source/platform/WebProcessMemoryDump.h b/third_party/WebKit/Source/platform/WebProcessMemoryDump.h

index ed0eb121b6cd7bdaa9e666f38c25496fa6397b9b..d8f8e845dba9dbb0d447d97d7535f614a2fdda1d 100644

--- a/third_party/WebKit/Source/platform/WebProcessMemoryDump.h

+++ b/third_party/WebKit/Source/platform/WebProcessMemoryDump.h

@@ -97,7 +97,7 @@ public:

virtual blink::WebMemoryAllocatorDump* createDiscardableMemoryAllocatorDump(const std::string& name, base::DiscardableMemory*) = 0;

// Dumps heap memory usage. |allocatorName| is used as an absolute name for

- // base::trace_event::ProcessMemoryDump::AddHeapDump.

+ // base::trace_event::ProcessMemoryDump::DumpHeapUsage().

virtual void dumpHeapUsage(const base::hash_map<base::trace_event::AllocationContext, base::trace_event::AllocationMetrics>& metricsByContext, base::trace_event::TraceEventMemoryOverhead&, const char* allocatorName) = 0;

};