Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

Issue 2016613002: Remove ProcessMemoryDump::AddHeapDump() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/WebProcessMemoryDump.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
diff --git a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
index e53e15bc050caac30b14981069ce4ded3aa75ffb..ae44d349d2ede613e776c2dde5e56c3c7796511f 100644
--- a/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
+++ b/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
@@ -172,17 +172,7 @@ void WebProcessMemoryDumpImpl::dumpHeapUsage(
base::trace_event::AllocationMetrics>& metrics_by_context,
base::trace_event::TraceEventMemoryOverhead& overhead,
const char* allocator_name) {
- if (!metrics_by_context.empty()) {
- scoped_refptr<base::trace_event::MemoryDumpSessionState> session_state =
- process_memory_dump_->session_state();
- std::unique_ptr<base::trace_event::TracedValue> heap_dump = ExportHeapDump(
- metrics_by_context, *session_state);
- process_memory_dump_->AddHeapDump(allocator_name, std::move(heap_dump));
- }
-
- std::string base_name = base::StringPrintf("tracing/heap_profiler_%s",
- allocator_name);
- overhead.DumpInto(base_name.c_str(), process_memory_dump_);
+ process_memory_dump_->DumpHeapUsage(metrics_by_context, overhead, allocator_name);
}
} // namespace content
« no previous file with comments | « third_party/WebKit/Source/platform/WebProcessMemoryDump.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698