Add NV12 texture conversion support.

Add NV12 texture conversion support.

If textures 1 and 2 passed into MakeFromYUVTexturesCopy are the same,
then treat the input as NV12 and sample from the g component of texture
2.

BUG=skia:5209
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016593002

Committed: https://skia.googlesource.com/skia/+/b445a57e6c36cce86580b618701b5af708a6f271

[jbauman, 2016-05-26 00:32:09]

Description was changed from

==========
Add NV12 texture conversion support.

If textures 1 and 2 passed into MakeFromYUVTexturesCopy are the same,
then treat the input as NV12 and sample from the g component of texture
2.

BUG=skia:5209
==========

to

==========
Add NV12 texture conversion support.

If textures 1 and 2 passed into MakeFromYUVTexturesCopy are the same,
then treat the input as NV12 and sample from the g component of texture
2.

BUG=skia:5209
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016593002
==========

[jbauman, 2016-05-26 00:33:57]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 00:34:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016593002/1

[commit-bot: I haz the power, 2016-05-26 00:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 00:37:34]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[jbauman, 2016-05-27 00:37:26]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 00:37:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016593002/20001

[commit-bot: I haz the power, 2016-05-27 00:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 00:50:44]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-27 00:50:55]

Dry run: None

[jbauman, 2016-05-27 01:08:11]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 01:08:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016593002/40001

[commit-bot: I haz the power, 2016-05-27 01:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 01:22:29]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-27 01:22:37]

Dry run: None

[jbauman, 2016-05-27 01:27:23]

jbauman@chromium.org changed reviewers:
+ bsalomon@google.com

[jbauman, 2016-05-27 01:27:24]

I'm not very familiar with skia's code or coding style, so let me know how this
overall approach looks.

[bsalomon, 2016-05-31 13:52:20]

This seems ok, but the inferred nature of the API is pretty subtle. Could we add
an enum to the MakeFromYUVTextureCopy API that differentiates the two types of
input texture configurations? Or add a new entry like MakeFromNV12TexturesCopy?

[jbauman, 2016-05-31 22:53:14]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 22:53:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016593002/60001

[commit-bot: I haz the power, 2016-05-31 22:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 22:57:55]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[jbauman, 2016-06-01 21:10:15]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 21:10:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016593002/60001

[commit-bot: I haz the power, 2016-06-01 21:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 21:18:31]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-06-01 21:37:08]

On 2016/05/31 13:52:20, bsalomon wrote:
> This seems ok, but the inferred nature of the API is pretty subtle. Could we
add
> an enum to the MakeFromYUVTextureCopy API that differentiates the two types of
> input texture configurations? Or add a new entry like
MakeFromNV12TexturesCopy?

Ok, added MakeFromNV12TexturesCopy.

[jbauman, 2016-06-08 21:54:49]

On 2016/06/01 21:37:08, jbauman wrote:
> On 2016/05/31 13:52:20, bsalomon wrote:
> > This seems ok, but the inferred nature of the API is pretty subtle. Could we
> add
> > an enum to the MakeFromYUVTextureCopy API that differentiates the two types
of
> > input texture configurations? Or add a new entry like
> MakeFromNV12TexturesCopy?
> 
> Ok, added MakeFromNV12TexturesCopy.

friendly ping.

[bsalomon, 2016-06-09 12:35:53]

On 2016/06/08 21:54:49, jbauman wrote:
> On 2016/06/01 21:37:08, jbauman wrote:
> > On 2016/05/31 13:52:20, bsalomon wrote:
> > > This seems ok, but the inferred nature of the API is pretty subtle. Could
we
> > add
> > > an enum to the MakeFromYUVTextureCopy API that differentiates the two
types
> of
> > > input texture configurations? Or add a new entry like
> > MakeFromNV12TexturesCopy?
> > 
> > Ok, added MakeFromNV12TexturesCopy.
> 
> friendly ping.

Oops, sorry for the delay! lgtm

[jbauman, 2016-06-09 18:27:54]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-06-09 18:28:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/60001

[commit-bot: I haz the power, 2016-06-09 18:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 18:29:30]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[jbauman, 2016-06-09 19:53:58]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-06-09 19:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2016593002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 19:54:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016593002/80001

[commit-bot: I haz the power, 2016-06-09 20:24:50]

Description was changed from

==========
Add NV12 texture conversion support.

If textures 1 and 2 passed into MakeFromYUVTexturesCopy are the same,
then treat the input as NV12 and sample from the g component of texture
2.

BUG=skia:5209
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016593002
==========

to

==========
Add NV12 texture conversion support.

If textures 1 and 2 passed into MakeFromYUVTexturesCopy are the same,
then treat the input as NV12 and sample from the g component of texture
2.

BUG=skia:5209
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016593002

Committed:
https://skia.googlesource.com/skia/+/b445a57e6c36cce86580b618701b5af708a6f271
==========

[commit-bot: I haz the power, 2016-06-09 20:24:51]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b445a57e6c36cce86580b618701b5af708a6f271

[bsalomon, 2016-06-10 17:08:46]

On 2016/06/09 20:24:51, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:80001) as
> https://skia.googlesource.com/skia/+/b445a57e6c36cce86580b618701b5af708a6f271

Hey John, could you triage the new images:
https://gold.skia.org/search?query=source_type%3Dgm%26name%3Dyuv_nv12_to_rgb_...

If they look right to you, just click the check boxes below the images.