Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2016413002: [cronet] Temporarily suppress WrongConstant lint warning in two places. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
pauljensen, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cronet] Temporarily suppress WrongConstant lint warning in two places. BUG=615045 Committed: https://crrev.com/25fbe7b5f5705b3b6f58a542749cc1435769bdcc Cr-Commit-Position: refs/heads/master@{#396514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java View 2 chunks +2 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
Context on the bug. I don't mind switching to the RetentionPolicy change if you'd prefer ...
4 years, 6 months ago (2016-05-27 17:29:14 UTC) #2
xunjieli
On 2016/05/27 17:29:14, jbudorick wrote: > Context on the bug. I don't mind switching to ...
4 years, 6 months ago (2016-05-27 17:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016413002/1
4 years, 6 months ago (2016-05-27 17:35:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 18:15:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/25fbe7b5f5705b3b6f58a542749cc1435769bdcc Cr-Commit-Position: refs/heads/master@{#396514}
4 years, 6 months ago (2016-05-27 18:17:16 UTC) #8
pauljensen
4 years, 6 months ago (2016-05-31 12:51:03 UTC) #9
Message was sent while issue was closed.
We should be using the @IntDef stuff for creating UrlRequest priorities too. 
When we remove the suppressions from this CL we should also add the annotations
for UrlRequest priority.

Powered by Google App Engine
This is Rietveld 408576698