Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2016413002: [cronet] Temporarily suppress WrongConstant lint warning in two places. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.annotation.SuppressLint;
7 import android.content.Context; 8 import android.content.Context;
8 import android.net.http.HttpResponseCache; 9 import android.net.http.HttpResponseCache;
9 import android.support.annotation.IntDef; 10 import android.support.annotation.IntDef;
10 import android.support.annotation.Nullable; 11 import android.support.annotation.Nullable;
11 import android.util.Log; 12 import android.util.Log;
12 13
13 import java.io.File; 14 import java.io.File;
14 import java.io.IOException; 15 import java.io.IOException;
15 import java.lang.annotation.Retention; 16 import java.lang.annotation.Retention;
16 import java.lang.annotation.RetentionPolicy; 17 import java.lang.annotation.RetentionPolicy;
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 * Executor, int priority)}. 636 * Executor, int priority)}.
636 * 637 *
637 * @param url {@link URL} for the request. 638 * @param url {@link URL} for the request.
638 * @param callback callback object that gets invoked on different events. 639 * @param callback callback object that gets invoked on different events.
639 * @param executor {@link Executor} on which all callbacks will be invoked. 640 * @param executor {@link Executor} on which all callbacks will be invoked.
640 * @return new request. 641 * @return new request.
641 * @deprecated Use {@link UrlRequest.Builder#build}. 642 * @deprecated Use {@link UrlRequest.Builder#build}.
642 * @hide 643 * @hide
643 */ 644 */
644 @Deprecated 645 @Deprecated
646 @SuppressLint("WrongConstant") // TODO(jbudorick): Remove this after rolling to the N SDK.
645 public final UrlRequest createRequest( 647 public final UrlRequest createRequest(
646 String url, UrlRequest.Callback callback, Executor executor) { 648 String url, UrlRequest.Callback callback, Executor executor) {
647 return createRequest(url, callback, executor, UrlRequest.Builder.REQUEST _PRIORITY_MEDIUM); 649 return createRequest(url, callback, executor, UrlRequest.Builder.REQUEST _PRIORITY_MEDIUM);
648 } 650 }
649 651
650 /** 652 /**
651 * Creates a {@link UrlRequest} object. All callbacks will 653 * Creates a {@link UrlRequest} object. All callbacks will
652 * be called on {@code executor}'s thread. {@code executor} must not run 654 * be called on {@code executor}'s thread. {@code executor} must not run
653 * tasks on the current thread to prevent blocking networking operations 655 * tasks on the current thread to prevent blocking networking operations
654 * and causing exceptions during shutdown. 656 * and causing exceptions during shutdown.
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 * @hide as it's a prototype. 1106 * @hide as it's a prototype.
1105 */ 1107 */
1106 public interface RequestFinishedListener { // TODO(klm): Add a convenience a bstract class. 1108 public interface RequestFinishedListener { // TODO(klm): Add a convenience a bstract class.
1107 /** 1109 /**
1108 * Invoked with request info. 1110 * Invoked with request info.
1109 * @param requestInfo {@link UrlRequestInfo} for finished request. 1111 * @param requestInfo {@link UrlRequestInfo} for finished request.
1110 */ 1112 */
1111 void onRequestFinished(UrlRequestInfo requestInfo); 1113 void onRequestFinished(UrlRequestInfo requestInfo);
1112 } 1114 }
1113 } 1115 }
OLDNEW
« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698