Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

Issue 2016413002: [cronet] Temporarily suppress WrongConstant lint warning in two places. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/android/api/src/org/chromium/net/CronetEngine.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.annotation.SuppressLint;
7 import android.support.annotation.IntDef; 8 import android.support.annotation.IntDef;
8 9
9 import java.lang.annotation.Retention; 10 import java.lang.annotation.Retention;
10 import java.lang.annotation.RetentionPolicy; 11 import java.lang.annotation.RetentionPolicy;
11 import java.nio.ByteBuffer; 12 import java.nio.ByteBuffer;
12 import java.util.AbstractMap; 13 import java.util.AbstractMap;
13 import java.util.ArrayList; 14 import java.util.ArrayList;
14 import java.util.Map; 15 import java.util.Map;
15 import java.util.concurrent.Executor; 16 import java.util.concurrent.Executor;
16 17
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 } 175 }
175 176
176 /** 177 /**
177 * Creates a {@link BidirectionalStream} using configuration from this 178 * Creates a {@link BidirectionalStream} using configuration from this
178 * {@link Builder}. The returned {@code BidirectionalStream} can then be started 179 * {@link Builder}. The returned {@code BidirectionalStream} can then be started
179 * by calling {@link BidirectionalStream#start}. 180 * by calling {@link BidirectionalStream#start}.
180 * 181 *
181 * @return constructed {@link BidirectionalStream} using configuration f rom 182 * @return constructed {@link BidirectionalStream} using configuration f rom
182 * this {@link Builder} 183 * this {@link Builder}
183 */ 184 */
185 @SuppressLint("WrongConstant") // TODO(jbudorick): Remove this after rol ling to the N SDK.
184 public BidirectionalStream build() { 186 public BidirectionalStream build() {
185 return mCronetEngine.createBidirectionalStream(mUrl, mCallback, mExe cutor, mHttpMethod, 187 return mCronetEngine.createBidirectionalStream(mUrl, mCallback, mExe cutor, mHttpMethod,
186 mRequestHeaders, mPriority, mDisableAutoFlush); 188 mRequestHeaders, mPriority, mDisableAutoFlush);
187 } 189 }
188 } 190 }
189 191
190 /** 192 /**
191 * Callback class used to receive callbacks from a {@link BidirectionalStrea m}. 193 * Callback class used to receive callbacks from a {@link BidirectionalStrea m}.
192 */ 194 */
193 public abstract static class Callback { 195 public abstract static class Callback {
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 /** 419 /**
418 * Returns {@code true} if the stream was successfully started and is now 420 * Returns {@code true} if the stream was successfully started and is now
419 * done (succeeded, canceled, or failed). 421 * done (succeeded, canceled, or failed).
420 * 422 *
421 * @return {@code true} if the stream was successfully started and is now 423 * @return {@code true} if the stream was successfully started and is now
422 * done (completed, canceled, or failed), otherwise returns {@code f alse} 424 * done (completed, canceled, or failed), otherwise returns {@code f alse}
423 * to indicate stream is not yet started or is in progress. 425 * to indicate stream is not yet started or is in progress.
424 */ 426 */
425 public abstract boolean isDone(); 427 public abstract boolean isDone();
426 } 428 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/api/src/org/chromium/net/CronetEngine.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698