chromecast/browser/media/media_pipeline_backend_factory.h - Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/media/media_pipeline_backend_factory.h

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Add implementation to use audio_device_id in CastRender. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/media/cast_renderer.cc ('K') | « chromecast/browser/media/cast_renderer.cc ('k') | chromecast/browser/media/media_pipeline_host.cc » ('j') | media/mojo/interfaces/service_factory.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/media/media_pipeline_backend_factory.h

diff --git a/chromecast/browser/media/media_pipeline_backend_factory.h b/chromecast/browser/media/media_pipeline_backend_factory.h

index 9f59bb9af7fe5104085ae779e910b9d704b836be..d7cf886e8637340d2d57f890be65e37e6d08b2ab 100644

--- a/chromecast/browser/media/media_pipeline_backend_factory.h

+++ b/chromecast/browser/media/media_pipeline_backend_factory.h

@@ -15,8 +15,8 @@ namespace chromecast {

namespace media {

typedef base::Callback<std::unique_ptr<MediaPipelineBackend>(

- const MediaPipelineDeviceParams&)>

- CreateMediaPipelineBackendCB;

+ const MediaPipelineDeviceParams&,

+ int stream_type)> CreateMediaPipelineBackendCB;

kmackay 2016/07/12 05:20:31 I think it would be better to take the device ID s

tianyuwang1 2016/07/12 15:28:09 Done.

} // media

} // chromecast